Bug 178557

Summary: Enable gigacage on iOS with a 32GB runway and ensure it doesn't break WasmBench
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing
none
patch for landing
none
patch for landing
none
patch for landing
none
patch for landing none

Saam Barati
Reported 2017-10-19 19:09:51 PDT
...
Attachments
patch (3.38 KB, patch)
2017-12-07 12:47 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (3.72 KB, patch)
2017-12-07 13:05 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (4.22 KB, patch)
2017-12-07 13:09 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (4.27 KB, patch)
2017-12-07 13:12 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (3.99 KB, patch)
2017-12-07 13:13 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (3.99 KB, patch)
2017-12-07 13:24 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-12-07 11:49:31 PST
Patch forthcoming.
Saam Barati
Comment 2 2017-12-07 11:59:08 PST
*** Bug 177605 has been marked as a duplicate of this bug. ***
Saam Barati
Comment 3 2017-12-07 12:47:11 PST
Created attachment 328718 [details] patch I think this should do it. But we'll see what EWS says w.r.t building on other platforms.
Mark Lam
Comment 4 2017-12-07 12:57:19 PST
Comment on attachment 328718 [details] patch r=me
Saam Barati
Comment 5 2017-12-07 13:05:05 PST
Created attachment 328720 [details] patch for landing Curious why static assert is failing on x86-32. I made the static assert have a better error message.
Saam Barati
Comment 6 2017-12-07 13:09:57 PST
Created attachment 328722 [details] patch for landing Fix 32-bit compiles since size_t is 32-bit on 32-bit platforms.
Saam Barati
Comment 7 2017-12-07 13:12:25 PST
Created attachment 328724 [details] patch for landing
Saam Barati
Comment 8 2017-12-07 13:13:56 PST
Created attachment 328725 [details] patch for landing
Saam Barati
Comment 9 2017-12-07 13:24:33 PST
Created attachment 328728 [details] patch for landing
WebKit Commit Bot
Comment 10 2017-12-08 14:28:34 PST
Comment on attachment 328728 [details] patch for landing Clearing flags on attachment: 328728 Committed r225701: <https://trac.webkit.org/changeset/225701>
WebKit Commit Bot
Comment 11 2017-12-08 14:28:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-12-08 14:29:36 PST
<rdar://problem/35943687>
Note You need to log in before you can comment on or make changes to this bug.