Bug 176891

Summary: [WinCairo] Add an option to build WebKitLegacy or WebKit
Product: WebKit Reporter: Yousuke Kimoto <Yousuke.Kimoto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, don.olmstead, webkit-bug-importer, yoshiaki.jitsukawa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174003    
Attachments:
Description Flags
[PATCH] Add an option to build WebKitLegacy or WebKit none

Yousuke Kimoto
Reported 2017-09-13 23:54:10 PDT
To build WebKitLegacy and WebKit on WinCairo, we'd like to introduce ENABLE_WEBKIT_LEGACY for WInCiaro's CMake files to choose the two architecture. For WebKitLegacy: $ perl Tools\Scripts\build-webkit --no-ninja --wincairo --64-bit For WebKit: $ perl Tools\Scripts\build-webkit --no-ninja --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF"
Attachments
[PATCH] Add an option to build WebKitLegacy or WebKit (2.30 KB, patch)
2017-09-14 01:45 PDT, Yousuke Kimoto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yousuke Kimoto
Comment 1 2017-09-14 01:45:14 PDT
Created attachment 320749 [details] [PATCH] Add an option to build WebKitLegacy or WebKit
Alex Christensen
Comment 2 2017-09-14 10:46:31 PDT
Comment on attachment 320749 [details] [PATCH] Add an option to build WebKitLegacy or WebKit Won't we want to add an else to both of these conditions?
Don Olmstead
Comment 3 2017-09-14 18:13:54 PDT
Comment on attachment 320749 [details] [PATCH] Add an option to build WebKitLegacy or WebKit Ok so I got some clarification this will work with the following command perl Tools\Scripts\build-webkit --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF" In this case the root CMakeLists.txt has if (NOT DEFINED ENABLE_WEBKIT) set(ENABLE_WEBKIT ON) endif () So this will end up building with WebKit instead of WebKitLegacy.
WebKit Commit Bot
Comment 4 2017-09-14 18:42:56 PDT
Comment on attachment 320749 [details] [PATCH] Add an option to build WebKitLegacy or WebKit Clearing flags on attachment: 320749 Committed r222070: <http://trac.webkit.org/changeset/222070>
WebKit Commit Bot
Comment 5 2017-09-14 18:42:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:34:13 PDT
<rdar://problem/34693503>
Note You need to log in before you can comment on or make changes to this bug.