Bug 176273

Summary: Move UI Process part of the Remote Layer Tree code out of a Mac-specific directory
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174097    
Attachments:
Description Flags
Patch
none
Patch
mitz: review+
Patch for EWS none

Tim Horton
Reported 2017-09-02 01:09:00 PDT
Move UI Process part of the Remote Layer Tree code out of a Mac-specific directory
Attachments
Patch (324.51 KB, patch)
2017-09-02 01:15 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (243.02 KB, patch)
2017-09-02 01:42 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
Patch for EWS (243.02 KB, patch)
2017-09-02 15:53 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-09-02 01:15:25 PDT
Created attachment 319705 [details] Patch
Tim Horton
Comment 2 2017-09-02 01:16:08 PDT
Oh, webkit-patch -g, you never quite do the right thing :(
Tim Horton
Comment 3 2017-09-02 01:42:49 PDT
Created attachment 319711 [details] Patch
mitz
Comment 4 2017-09-02 01:44:24 PDT
Comment on attachment 319711 [details] Patch rs=me
Tim Horton
Comment 5 2017-09-02 15:53:45 PDT
Created attachment 319743 [details] Patch for EWS
Build Bot
Comment 6 2017-09-02 15:55:44 PDT
Attachment 319743 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:446: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.h:27: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:30: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/PlatformMac.cmake:281: Alphabetical sorting problem. "UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm" should be before "UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp". [list/order] [5] Total errors found: 10 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2017-09-02 16:52:38 PDT
Comment on attachment 319743 [details] Patch for EWS Clearing flags on attachment: 319743 Committed r221541: <http://trac.webkit.org/changeset/221541>
WebKit Commit Bot
Comment 8 2017-09-02 16:52:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-27 12:39:20 PDT
<rdar://problem/34693694>
Note You need to log in before you can comment on or make changes to this bug.