Bug 175417

Summary: Text renderer updates should be done by RenderTreeUpdater
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, kling, ryanhaddad, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 163848    
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2017-08-10 01:40:42 PDT
Currently Text does some direct render tree mutations.
Attachments
patch (9.58 KB, patch)
2017-08-10 01:49 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-08-10 01:49:15 PDT
Created attachment 317797 [details] patch
Andreas Kling
Comment 2 2017-08-10 02:49:38 PDT
Comment on attachment 317797 [details] patch r=me
WebKit Commit Bot
Comment 3 2017-08-10 03:20:56 PDT
Comment on attachment 317797 [details] patch Clearing flags on attachment: 317797 Committed r220523: <http://trac.webkit.org/changeset/220523>
WebKit Commit Bot
Comment 4 2017-08-10 03:20:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-08-10 03:22:14 PDT
<rdar://problem/33824787>
Ryan Haddad
Comment 6 2017-08-10 08:35:36 PDT
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 317797 [details] > patch > > Clearing flags on attachment: 317797 > > Committed r220523: <http://trac.webkit.org/changeset/220523> This change broke the Windows build (as EWS predicted): https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/3582
Note You need to log in before you can comment on or make changes to this bug.