Bug 175280

Summary: Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://w3c.github.io/beacon/#sec-processing-model
Bug Depends on:    
Bug Blocks: 175264    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews101 for mac-elcapitan
none
Patch none

Chris Dumez
Reported 2017-08-07 13:00:50 PDT
Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest. FetchBody for data destruction is really the only thing we need at the moment. The new code also properly sets the CORS mode, which will be needed for Bug 175264.
Attachments
Patch (3.24 KB, patch)
2017-08-07 13:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2017-08-07 14:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (1005.25 KB, application/zip)
2017-08-07 15:27 PDT, Build Bot 		no flags
Details
Patch (3.21 KB, patch)
2017-08-07 15:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-08-07 13:03:31 PDT
Created attachment 317454 [details] Patch
youenn fablet
Comment 2 2017-08-07 14:11:26 PDT
Comment on attachment 317454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317454&action=review > Source/WebCore/ChangeLog:9 > + for data destruction is really the only thing we need at the moment. data extraction? > Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:35 > #include <runtime/JSCJSValue.h> Do you still need that include? > Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:64 > + options.redirect = FetchOptions::Redirect::Follow; No need to set redirect to follow, this is the default and is not spelled out in the spec explicitly. > Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:65 > + options.cache = FetchOptions::Cache::NoCache; I do not see that option set in the spec. I forgot to ask why it was set in previous patches.
Chris Dumez
Comment 3 2017-08-07 14:17:56 PDT
Created attachment 317463 [details] Patch
Build Bot
Comment 4 2017-08-07 15:27:30 PDT
Comment on attachment 317463 [details] Patch Attachment 317463 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4272222 New failing tests: http/tests/blink/sendbeacon/beacon-same-origin.html
Build Bot
Comment 5 2017-08-07 15:27:31 PDT
Created attachment 317480 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Chris Dumez
Comment 6 2017-08-07 15:30:03 PDT
Created attachment 317482 [details] Patch
WebKit Commit Bot
Comment 7 2017-08-07 16:22:15 PDT
Comment on attachment 317482 [details] Patch Clearing flags on attachment: 317482 Committed r220366: <http://trac.webkit.org/changeset/220366>
WebKit Commit Bot
Comment 8 2017-08-07 16:22:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-07 16:23:18 PDT
<rdar://problem/33764771>
Note You need to log in before you can comment on or make changes to this bug.