Bug 174420

Summary: [WebCrypto] Add PKCS#8 import test that covers `parameters` and `publicKey` values in ECPrivateKey
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 173647    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Zan Dobersek
Reported 2017-07-12 04:47:21 PDT
SSIA. Spin-off from bug #173647. https://bugs.webkit.org/show_bug.cgi?id=173647
Attachments
Patch (10.18 KB, patch)
2017-07-31 04:05 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (30.54 KB, patch)
2017-08-01 04:04 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.30 KB, patch)
2017-08-01 12:03 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-07-31 04:05:28 PDT
Created attachment 316762 [details] Patch
Jiewen Tan
Comment 2 2017-07-31 13:31:08 PDT
Comment on attachment 316762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316762&action=review > LayoutTests/ChangeLog:3 > + [WebCrypto] Add PKCS#8 import test that covers `parameters` and `publicKey` values in ECPrivateKey Where is the `publicKey` part?
Zan Dobersek
Comment 3 2017-08-01 01:25:46 PDT
Hum.
Zan Dobersek
Comment 4 2017-08-01 04:04:16 PDT
Created attachment 316843 [details] Patch
Darin Adler
Comment 5 2017-08-01 09:05:31 PDT
Comment on attachment 316843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316843&action=review > LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html:61 > +<script src="../../resources/js-test-post.js"></script> This is old style. For new tests we should just use js-test.js at the start, not both pre/post. > LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html:61 > +<script src="../../resources/js-test-post.js"></script> Ditto. > LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html:61 > +<script src="../../resources/js-test-post.js"></script> Ditto. > LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html:61 > +<script src="../../resources/js-test-post.js"></script> Ditto.
Zan Dobersek
Comment 6 2017-08-01 12:03:46 PDT
Created attachment 316878 [details] Patch for landing
Zan Dobersek
Comment 7 2017-08-01 12:18:14 PDT
Comment on attachment 316878 [details] Patch for landing Clearing flags on attachment: 316878 Committed r220108: <http://trac.webkit.org/changeset/220108>
Zan Dobersek
Comment 8 2017-08-01 12:18:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-01 12:19:23 PDT
<rdar://problem/33659443>
Note You need to log in before you can comment on or make changes to this bug.