Bug 174338

Summary: Web Inspector: [PARITY] Styles Redesign: Implement warning icons
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 145982    
Bug Blocks:    
Attachments:
Description Flags
[Image] Bug none

Nikita Vasilyev
Reported 2017-07-10 17:07:41 PDT
Created attachment 315049 [details] [Image] Bug CSS warning icons in the styles sidebar should be on far left, and they shouldn't shift text. Also, we should never show more than one warning icon per line.
Attachments
[Image] Bug (55.90 KB, image/png)
2017-07-10 17:07 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-10 17:10:12 PDT
<rdar://problem/33226440>
Matt Baker
Comment 2 2017-07-10 17:54:03 PDT
(In reply to Nikita Vasilyev from comment #0) > Created attachment 315049 [details] > [Image] Bug > > CSS warning icons in the styles sidebar should be on far left, and they > shouldn't shift text. > > Also, we should never show more than one warning icon per line. I remember addressing both of these in https://bugs.webkit.org/show_bug.cgi?id=170281. Was there a regression, or did that fix not cover all the situations where this can occur? Steps to reproduce?
Matt Baker
Comment 3 2017-07-10 17:59:20 PDT
(In reply to Matt Baker from comment #2) > (In reply to Nikita Vasilyev from comment #0) > > Created attachment 315049 [details] > > [Image] Bug > > > > CSS warning icons in the styles sidebar should be on far left, and they > > shouldn't shift text. Agree, shifting the style text to make room is terrible. The icon could occupy the same position as the checkbox. It feels weird to be able to enable/disable a style with a warning/strikethrough, but maybe there is a use case here. > > > > Also, we should never show more than one warning icon per line. This was the issue I was thinking of. Can this still happen? > > I remember addressing both of these in > https://bugs.webkit.org/show_bug.cgi?id=170281. Was there a regression, or > did that fix not cover all the situations where this can occur? Steps to > reproduce?
Nikita Vasilyev
Comment 4 2017-10-13 15:46:18 PDT
Retitling and converting this bug to a task. The new styles sidebar doesn't have any warning icons yet. The plan is to show at most one warning icon per property and show them on a side (not inline).
Devin Rousso
Comment 5 2017-12-14 21:04:50 PST
*** This bug has been marked as a duplicate of bug 179215 ***
Note You need to log in before you can comment on or make changes to this bug.