Bug 174272

Summary:

LayoutTest inspector/canvas/css-canvas-clients.html is a flaky timeout

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

NEW

Severity:

Normal

CC:

bburg, ehutchison, ews-watchlist, hi, inspector-bugzilla-changes, jenner, joepeck, mattbaker, rniwa, sam, simon.fraser, sroberts, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=162814
https://bugs.webkit.org/show_bug.cgi?id=158006

Bug Depends on:

173965

Bug Blocks:

Attachments:

Description	Flags
[Patch] Remove TestExpectation	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Archive of layout-test-results from ews215 for win-future	none
[Patch] Extra Logging	hi: commit-queue-
[Patch] Extra Logging	hi: commit-queue-
Archive of layout-test-results from ews102 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
[Patch] Extra Logging	hi: commit-queue-
[Patch] Extra Logging	hi: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
[Patch] Extra Logging	hi: commit-queue-
[Patch] Extra Logging	hi: commit-queue-
[Patch] Extra Logging	hi: commit-queue-
[Patch] Extra Logging	hi: commit-queue-
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Archive of layout-test-results from ews101 for mac-highsierra	none
[Patch] Extra Logging	hi: commit-queue-
[Patch] Extra Logging	none
Patch	none
Archive of layout-test-results from ews213 for win-future	none
Update Test Expectations	none

Devin Rousso

Reported 2017-07-07 13:50:41 PDT

LayoutTest inspector/canvas/css-canvas-clients.html is a flaky timeout https://webkit-queues.webkit.org/results/4046639

Attachments
[Patch] Remove TestExpectation (991 bytes, patch) 2019-05-11 14:02 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.19 MB, application/zip) 2019-05-11 14:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (2.88 MB, application/zip) 2019-05-11 15:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews215 for win-future (13.47 MB, application/zip) 2019-05-11 19:01 PDT, EWS Watchlist	no flags	Details
[Patch] Extra Logging (6.49 KB, patch) 2019-05-12 13:10 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
[Patch] Extra Logging (6.49 KB, patch) 2019-05-12 20:01 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (3.21 MB, application/zip) 2019-05-12 21:06 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (3.04 MB, application/zip) 2019-05-12 21:58 PDT, EWS Watchlist	no flags	Details
[Patch] Extra Logging (8.86 KB, patch) 2019-05-12 23:03 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
[Patch] Extra Logging (9.58 KB, patch) 2019-05-12 23:05 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.23 MB, application/zip) 2019-05-13 00:17 PDT, EWS Watchlist	no flags	Details
[Patch] Extra Logging (10.87 KB, patch) 2019-05-13 00:47 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
[Patch] Extra Logging (11.23 KB, patch) 2019-05-13 00:52 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
[Patch] Extra Logging (11.83 KB, patch) 2019-05-13 00:57 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
[Patch] Extra Logging (11.24 KB, patch) 2019-05-13 00:57 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.09 MB, application/zip) 2019-05-13 01:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews101 for mac-highsierra (3.11 MB, application/zip) 2019-05-13 02:04 PDT, EWS Watchlist	no flags	Details
[Patch] Extra Logging (11.90 KB, patch) 2019-05-13 02:36 PDT, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
[Patch] Extra Logging (10.84 KB, patch) 2019-05-13 11:57 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (7.06 KB, patch) 2019-05-13 13:29 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (13.41 MB, application/zip) 2019-05-14 09:24 PDT, EWS Watchlist	no flags	Details
Update Test Expectations (1.73 KB, patch) 2021-07-16 10:51 PDT, Eric Hutchison	no flags	Details Formatted Diff Diff
Show Obsolete (21) View All Add attachment proposed patch, testcase, etc.

Shawn Roberts

Comment 1 2019-04-08 13:34:38 PDT

After changes in https://trac.webkit.org/changeset/243953/webkit the test is showing it is failing, but it appears its just causing itself to time out. It is affecting all WK1 Release and Debug builds. Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Fcss-canvas-clients.html Diff: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r244020%20(4238)/inspector/canvas/css-canvas-clients-diff.txt

Radar WebKit Bug Importer

Comment 2 2019-04-08 13:35:28 PDT

<rdar://problem/49709077>

Shawn Roberts

Comment 3 2019-04-08 13:49:27 PDT

Skipped test in https://trac.webkit.org/changeset/244041/webkit while waiting for a fix.

Shawn Roberts

Comment 4 2019-04-09 11:08:14 PDT

Unskipped test and just marked as a flaky failure since timeout no longer occurs, it just fails due to code changes. https://trac.webkit.org/changeset/244084/webkit

Devin Rousso

Comment 5 2019-05-11 14:02:37 PDT

Created attachment 369660 [details] [Patch] Remove TestExpectation This is passing for me, so let's see what the bots think

EWS Watchlist

Comment 6 2019-05-11 14:54:40 PDT Comment hidden (obsolete)

Comment on attachment 369660 [details] [Patch] Remove TestExpectation Attachment 369660 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12164550 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 7 2019-05-11 14:54:41 PDT Comment hidden (obsolete)

Created attachment 369661 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-05-11 15:59:19 PDT Comment hidden (obsolete)

Comment on attachment 369660 [details] [Patch] Remove TestExpectation Attachment 369660 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12164657 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 9 2019-05-11 15:59:21 PDT Comment hidden (obsolete)

Created attachment 369665 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 10 2019-05-11 19:01:10 PDT Comment hidden (obsolete)

Comment on attachment 369660 [details] [Patch] Remove TestExpectation Attachment 369660 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12165573 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html js/dom/custom-constructors.html

EWS Watchlist

Comment 11 2019-05-11 19:01:12 PDT Comment hidden (obsolete)

Created attachment 369666 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Devin Rousso

Comment 12 2019-05-12 13:10:04 PDT

Created attachment 369682 [details] [Patch] Extra Logging

Devin Rousso

Comment 13 2019-05-12 20:01:08 PDT

Created attachment 369689 [details] [Patch] Extra Logging

EWS Watchlist

Comment 14 2019-05-12 21:06:47 PDT Comment hidden (obsolete)

Comment on attachment 369689 [details] [Patch] Extra Logging Attachment 369689 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12172447 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 15 2019-05-12 21:06:49 PDT Comment hidden (obsolete)

Created attachment 369691 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 16 2019-05-12 21:58:24 PDT Comment hidden (obsolete)

Comment on attachment 369689 [details] [Patch] Extra Logging Attachment 369689 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12172558 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 17 2019-05-12 21:58:26 PDT Comment hidden (obsolete)

Created attachment 369693 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 18 2019-05-12 23:03:29 PDT

Created attachment 369696 [details] [Patch] Extra Logging

Devin Rousso

Comment 19 2019-05-12 23:05:36 PDT

Created attachment 369697 [details] [Patch] Extra Logging

EWS Watchlist

Comment 20 2019-05-13 00:17:57 PDT Comment hidden (obsolete)

Comment on attachment 369697 [details] [Patch] Extra Logging Attachment 369697 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12173571 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 21 2019-05-13 00:17:59 PDT Comment hidden (obsolete)

Created attachment 369701 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 22 2019-05-13 00:32:46 PDT

Comment on attachment 369697 [details] [Patch] Extra Logging View in context: https://bugs.webkit.org/attachment.cgi?id=369697&action=review > Source/WebCore/css/CSSImageGeneratorValue.cpp:81 > if (HTMLCanvasElement* canvasElement = downcast<CSSCanvasValue>(this)->element()) It looks like this line is the primary issue. `WebCore::CSSCanvasValue::element()` just fetches the stored `m_element` value, which (in this case) hasn't been initialized yet. Another (possibly bigger) issue is that `WebCore::CSSCanvasValue::element(Document&)` never gets called, which means we never add an observer. Not sure why that is.

Devin Rousso

Comment 23 2019-05-13 00:47:37 PDT

Created attachment 369703 [details] [Patch] Extra Logging

Devin Rousso

Comment 24 2019-05-13 00:48:47 PDT

Comment on attachment 369703 [details] [Patch] Extra Logging View in context: https://bugs.webkit.org/attachment.cgi?id=369703&action=review > Source/WebCore/css/CSSCanvasValue.cpp:46 > + if (auto* canvasElement = element(renderer.document())) This is probably "wrong", in that we shouldn't be eagerly creating the HTMLCanvasElement _only_ when Web Inspector is open. I'm curious to see if this will fix the test, however.

Devin Rousso

Comment 25 2019-05-13 00:52:58 PDT

Created attachment 369704 [details] [Patch] Extra Logging

Devin Rousso

Comment 26 2019-05-13 00:57:03 PDT

Created attachment 369705 [details] [Patch] Extra Logging

Devin Rousso

Comment 27 2019-05-13 00:57:52 PDT

Created attachment 369706 [details] [Patch] Extra Logging

EWS Watchlist

Comment 28 2019-05-13 01:54:54 PDT Comment hidden (obsolete)

Comment on attachment 369706 [details] [Patch] Extra Logging Attachment 369706 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12174335 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 29 2019-05-13 01:54:56 PDT Comment hidden (obsolete)

Created attachment 369713 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 30 2019-05-13 02:04:15 PDT Comment hidden (obsolete)

Comment on attachment 369706 [details] [Patch] Extra Logging Attachment 369706 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12174555 New failing tests: inspector/canvas/css-canvas-clients.html

EWS Watchlist

Comment 31 2019-05-13 02:04:16 PDT Comment hidden (obsolete)

Created attachment 369716 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 32 2019-05-13 02:36:31 PDT

Created attachment 369720 [details] [Patch] Extra Logging

Devin Rousso

Comment 33 2019-05-13 11:57:33 PDT

Created attachment 369758 [details] [Patch] Extra Logging

Devin Rousso

Comment 34 2019-05-13 13:29:14 PDT

Created attachment 369775 [details] Patch This feels "wrong" in that Web Inspector shouldn't be forcing/eagerly-creating anything. It's even weirder that it's only an issue in debug...

EWS Watchlist

Comment 35 2019-05-14 09:24:32 PDT Comment hidden (obsolete)

Comment on attachment 369775 [details] Patch Attachment 369775 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12188216 New failing tests: imported/blink/fast/canvas/bug382588.html

EWS Watchlist

Comment 36 2019-05-14 09:24:35 PDT Comment hidden (obsolete)

Created attachment 369859 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Devin Rousso

Comment 37 2019-06-06 17:24:30 PDT

Comment on attachment 369775 [details] Patch I don't think this is the right way forward.

Eric Hutchison

Comment 38 2021-07-16 10:36:13 PDT

Timeouts recurring on all Mac platforms as of r279104: Diff: --- /Volumes/Data/worker/bigsur-debug-applesilicon-tests-wk2/build/layout-test-results/inspector/canvas/requestClientNodes-css-expected.txt +++ /Volumes/Data/worker/bigsur-debug-applesilicon-tests-wk2/build/layout-test-results/inspector/canvas/requestClientNodes-css-actual.txt @@ -1,13 +1,5 @@ -Test that CanvasAgent tracks changes in the client nodes of a CSS canvas. +#PID UNRESPONSIVE - WebKitTestRunner (pid 59241) +FAIL: Timed out waiting for notifyDone to be called - -== Running test suite: Canvas.requestClientNodes.CSS --- Running test case: Canvas.requestClientNodes.CSS.Create -PASS: Canvas with created client should have CSS name "css-canvas". -PASS: There should be one client node. -PASS: Client node "div" is valid. - --- Running test case: Canvas.requestClientNodes.CSS.Destroy -PASS: Canvas with destroyed client should have CSS name "css-canvas". -PASS: There should be no client nodes. - +#EOF +#EOF

Eric Hutchison

Comment 39 2021-07-16 10:51:45 PDT

Created attachment 433685 [details] Update Test Expectations

Robert Jenner

Comment 40 2021-07-16 10:59:19 PDT

Comment on attachment 433685 [details] Update Test Expectations Clearing flags on attachment: 433685 Committed r279989 (239732@main): <https://commits.webkit.org/239732@main>

Note You need to log in before you can comment on or make changes to this bug.