Bug 174246

Summary: Speedometer 2.0: Fix deleting items in vanilla JS example
Product: WebKit Reporter: Mathias Bynens <mathias>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: addyo, buildbot, cdumez, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172339    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-elcapitan
none
Patch none

Mathias Bynens
Reported 2017-07-07 00:39:27 PDT
In the vanilla JS example, removing items doesn’t work: http://browserbench.org/Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/index.html I’ll submit a CL for this.
Attachments
Patch (3.92 KB, patch)
2017-07-07 00:47 PDT, Mathias Bynens 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (1.07 MB, application/zip)
2017-07-07 01:56 PDT, Build Bot 		no flags
Details
Patch (3.92 KB, patch)
2017-07-07 02:03 PDT, Mathias Bynens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mathias Bynens
Comment 1 2017-07-07 00:47:53 PDT
Created attachment 314822 [details] Patch
Build Bot
Comment 2 2017-07-07 01:56:37 PDT
Comment on attachment 314822 [details] Patch Attachment 314822 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4068870 New failing tests: fast/workers/dedicated-worker-lifecycle.html
Build Bot
Comment 3 2017-07-07 01:56:38 PDT
Created attachment 314823 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Ryosuke Niwa
Comment 4 2017-07-07 02:00:08 PDT
Comment on attachment 314822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314822&action=review Please fix the format of the change log entry. > PerformanceTests/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=174246 This line should appear immediately below the bug title. > PerformanceTests/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). Followed by this line, and then the description.
Mathias Bynens
Comment 5 2017-07-07 02:03:20 PDT
Created attachment 314824 [details] Patch
Ryosuke Niwa
Comment 6 2017-07-07 02:20:16 PDT
Comment on attachment 314824 [details] Patch Great. Thanks for the fix! In the future, please also set cq (commit-queue) to ? so that reviewers & committers can land your patch via the commit queue.
Mathias Bynens
Comment 7 2017-07-07 02:36:34 PDT
Thanks for the quick turnaround on this! Re: cq?, is there a way to tell `webkit-patch upload` to do that?
WebKit Commit Bot
Comment 8 2017-07-07 03:25:03 PDT
Comment on attachment 314824 [details] Patch Clearing flags on attachment: 314824 Committed r219251: <http://trac.webkit.org/changeset/219251>
WebKit Commit Bot
Comment 9 2017-07-07 03:25:05 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 10 2017-07-08 01:08:46 PDT
(In reply to Mathias Bynens from comment #7) > Thanks for the quick turnaround on this! > > Re: cq?, is there a way to tell `webkit-patch upload` to do that? webkit-patch upload --commit-queue would do.
Mathias Bynens
Comment 11 2017-07-10 04:44:10 PDT
> webkit-patch upload --commit-queue would do. $ webkit-patch upload --commit-queue Usage: webkit-patch [options] COMMAND [ARGS] webkit-patch: error: no such option: --commit-queue Type "webkit-patch --help" to see usage.
Ryosuke Niwa
Comment 12 2017-07-10 18:41:09 PDT
(In reply to Mathias Bynens from comment #11) > > webkit-patch upload --commit-queue would do. > > $ webkit-patch upload --commit-queue > Usage: webkit-patch [options] COMMAND [ARGS] > > webkit-patch: error: no such option: --commit-queue > > Type "webkit-patch --help" to see usage. Oops, it would be webkit-patch upload --request-commit
Note You need to log in before you can comment on or make changes to this bug.