Bug 174218
Summary: | Layout Test svg/animations/smil-leak-list-property-instances.svg is flaky | ||
---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | commit-queue, fujii.hironori, ryanhaddad, svillar, zimmermann |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=172545 https://bugs.webkit.org/show_bug.cgi?id=114280 |
Matt Lewis
svg/animations/smil-leak-list-property-instances.svg has become a flaky failure on Mac WK1 testers according to the flakiness dashboard.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=svg%2Fanimations%2Fsmil-leak-list-property-instances.svg
It started with this build:
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/2204
The last time the svg files were touched were with: https://trac.webkit.org/changeset/219045/webkit
However I have been unable to reproduce the failure locally and can't tell if the issue goes back further than this.
Current failure:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r219210%20(2308)/results.html
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/2308
Diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/svg/animations/animation-leak-list-property-instances-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/svg/animations/animation-leak-list-property-instances-actual.txt
@@ -1,3 +1,3 @@
This test checks that transform animations in SVG elements do not cause the whole SVGDocument to leak.
-PASS
+FAIL: not enough live nodes freed: 13 vs 4 expected
Recently another test that was added that was extremely flaky was showing the same diff as its output. Attaching bug in See also section
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Sergio Villar Senin
I'll try adding two collect() calls in a row as other tests do. It looks like previous tests might affect the results a lot.
Sergio Villar Senin
(In reply to Sergio Villar Senin from comment #1)
> I'll try adding two collect() calls in a row as other tests do. It looks
> like previous tests might affect the results a lot.
Beh I got confused with the test I added recently. AFAIK those tests where always flaky since the very beginning, and they're likely affecting the ones executing after them.
Matt Lewis
*** Bug 175701 has been marked as a duplicate of this bug. ***
Matt Lewis
Marked test as flaky on macOS WK1:
https://trac.webkit.org/changeset/220981/webkit
Fujii Hironori
*** This bug has been marked as a duplicate of bug 214574 ***