Bug 173330

Summary: Synchronous media query callbacks on nested frames could produced a detached FrameView.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jlewis3, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173375
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2017-06-13 14:30:15 PDT
rdar://problem/32487541
Attachments
Patch (3.14 KB, patch)
2017-06-13 14:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2017-06-13 16:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-06-13 14:45:12 PDT
Created attachment 312812 [details] Patch
alan
Comment 2 2017-06-13 14:45:51 PDT
see bug 173329 too.
Simon Fraser (smfr)
Comment 3 2017-06-13 14:49:09 PDT
Comment on attachment 312812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312812&action=review > Source/WebCore/page/FrameView.cpp:1522 > + // FIXME: Firing media query callbacks synchronously on nested frames could produced a detached FrameView here (webkit.org/b/173329). I would mention that a media query listener could trigger a navigation.
alan
Comment 4 2017-06-13 16:08:50 PDT
Created attachment 312824 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-13 17:18:52 PDT
The commit-queue encountered the following flaky tests while processing attachment 312824 [details]: media/media-source/media-source-unnecessary-seek-seeked.html bug 173344 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2017-06-13 17:19:25 PDT
Comment on attachment 312824 [details] Patch Clearing flags on attachment: 312824 Committed r218228: <http://trac.webkit.org/changeset/218228>
WebKit Commit Bot
Comment 7 2017-06-13 17:19:26 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 8 2017-06-14 18:23:57 PDT
After this patch was added, the test editing/execCommand/strikethrough-uses-strike-tag.html started failing on release builds Per Zalan, I Re-baselined the test. See bug: https://bugs.webkit.org/show_bug.cgi?id=173375 After the re-baseline, the test began to pass on release, but started to fail on Mac WK1 Debug.
Note You need to log in before you can comment on or make changes to this bug.