Bug 172708

Summary: [GTK] Stop dismissing menus attached to the web view for every injected event
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aperez, bugs-noreply, buildbot, lforschler, mcatanzaro, wenson_hsieh
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=40601
Bug Depends on:    
Bug Blocks: 171492    
Attachments:
Description Flags
Patch
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2 none

Carlos Garcia Campos
Reported 2017-05-30 05:52:21 PDT
It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send events while the menu is open.
Attachments
Patch (10.06 KB, patch)
2017-05-30 06:02 PDT, Carlos Garcia Campos 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (16.01 MB, application/zip)
2017-05-30 07:29 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-05-30 06:02:18 PDT
Created attachment 311501 [details] Patch
Build Bot
Comment 2 2017-05-30 07:29:53 PDT
Comment on attachment 311501 [details] Patch Attachment 311501 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3842034 New failing tests: fast/css/target-fragment-match.html
Build Bot
Comment 3 2017-05-30 07:29:54 PDT
Created attachment 311504 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Michael Catanzaro
Comment 4 2017-05-31 11:06:12 PDT
Awesome! Just needs approved by an owner.
Carlos Garcia Campos
Comment 5 2017-06-05 00:08:48 PDT
Ping Alex?
Carlos Garcia Campos
Comment 6 2017-06-09 00:04:28 PDT
Ping owners?
Alex Christensen
Comment 7 2017-06-09 10:30:34 PDT
This seems like it might be good, but I don't understand the implications of this to properly review it. I like that it removes platform-specific code, but will it work correctly on all platforms now? What is correct behavior? Can I verify this manually somehow?
Carlos Garcia Campos
Comment 8 2017-06-10 01:39:36 PDT
WebPage::contextMenuAtPointInWindow() is only used by WTR, so the fact that all tests keep passing should be enough, IMO.
Alex Christensen
Comment 9 2017-06-12 10:03:56 PDT
You're right. r=me
Carlos Garcia Campos
Comment 10 2017-06-12 10:09:06 PDT
(In reply to Alex Christensen from comment #9) > You're right. r=me Thanks!
Carlos Garcia Campos
Comment 11 2017-06-12 10:11:05 PDT
Committed r218106: <http://trac.webkit.org/changeset/218106>
Note You need to log in before you can comment on or make changes to this bug.