Bug 172565

Summary:

Add emoji support to wincairo

Product:

WebKit

Reporter:

isaac+webkit

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

don.olmstead, fujii.hironori, mmaxfield

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Windows 10

Bug Depends on:

204884, 205003, 205485

Bug Blocks:

Attachments:

Description	Flags
HTML page with smiling face emoji	none
Screenshot of rendering	none

isaac+webkit

Reported 2017-05-24 17:41:03 PDT

Created attachment 311169 [details] HTML page with smiling face emoji Using minibrowser when build with wincairo doesn't display emoji, even if fonts on the system support their display.

Attachments
HTML page with smiling face emoji (146 bytes, text/html) 2017-05-24 17:41 PDT, isaac+webkit	no flags	Details
Screenshot of rendering (15.19 KB, image/png) 2017-05-24 17:43 PDT, isaac+webkit	no flags	Details
View All Add attachment proposed patch, testcase, etc.

isaac+webkit

Comment 1 2017-05-24 17:43:57 PDT

Created attachment 311170 [details] Screenshot of rendering Shows the result of loading the test.html page in minibrowser.

Fujii Hironori

Comment 2 2017-05-24 18:52:11 PDT

There is my WIP patch in Bug 156579.

Fujii Hironori

Comment 3 2017-05-25 00:34:32 PDT

Sorry, I did misunderstand. WinCairo port doesn't use FreeType and HarfBuzz.

Don Olmstead

Comment 4 2017-05-25 10:25:47 PDT

We plan to move to FreeType HarfBuzz in the near future for the WinCairo port. I wouldn't try anything until that is completed.

Myles C. Maxfield

Comment 5 2017-05-25 10:55:46 PDT

> We plan to move to ... HarfBuzz Why? DirectWrite is more correct and doesn't require a third-party library.

Don Olmstead

Comment 6 2017-05-25 10:58:22 PDT

(In reply to Myles C. Maxfield from comment #5) > > We plan to move to ... HarfBuzz > > Why? DirectWrite is more correct and doesn't require a third-party library. We'd like things to match our PlayStation port which is Freetype and Harfbuzz

Myles C. Maxfield

Comment 7 2017-05-25 11:03:59 PDT

(In reply to Don Olmstead from comment #6) > (In reply to Myles C. Maxfield from comment #5) > > > We plan to move to ... HarfBuzz > > > > Why? DirectWrite is more correct and doesn't require a third-party library. > > We'd like things to match our PlayStation port which is Freetype and Harfbuzz The WinCairo port doesn't run on the PlayStation, though. It seems silly to make the WinCairo port worse because of a completely separate project.

Don Olmstead

Comment 8 2017-05-25 11:26:18 PDT

(In reply to Myles C. Maxfield from comment #7) > (In reply to Don Olmstead from comment #6) > > (In reply to Myles C. Maxfield from comment #5) > > > > We plan to move to ... HarfBuzz > > > > > > Why? DirectWrite is more correct and doesn't require a third-party library. > > > > We'd like things to match our PlayStation port which is Freetype and Harfbuzz > > The WinCairo port doesn't run on the PlayStation, though. It seems silly to > make the WinCairo port worse because of a completely separate project. There really aren't any maintainers for WinCairo so it made sense for us to make that call. When we're at that point I can always make it an option in the CMake configuration so people can choose the font shaping backend.

Myles C. Maxfield

Comment 9 2017-05-25 11:46:04 PDT

(In reply to Don Olmstead from comment #8) > (In reply to Myles C. Maxfield from comment #7) > > (In reply to Don Olmstead from comment #6) > > > (In reply to Myles C. Maxfield from comment #5) > > > > > We plan to move to ... HarfBuzz > > > > > > > > Why? DirectWrite is more correct and doesn't require a third-party library. > > > > > > We'd like things to match our PlayStation port which is Freetype and Harfbuzz > > > > The WinCairo port doesn't run on the PlayStation, though. It seems silly to > > make the WinCairo port worse because of a completely separate project. > > There really aren't any maintainers for WinCairo so it made sense for us to > make that call. When we're at that point I can always make it an option in > the CMake configuration so people can choose the font shaping backend. It's probably just a question of which ComplexTextController to compile, so switching it out should be easy.

Fujii Hironori

Comment 10 2020-01-22 22:49:49 PST

I fixed all Emoji bugs for WinCairo port. Closed this bug. Unfortunately, it supports only black and white Emoji because legacy Windows API doesn't support colorful Emoji. Please file a new ticket to track colorful Emoji support for WinCairo port.

Note You need to log in before you can comment on or make changes to this bug.