Bug 172494

Created attachment 310986 [details] Patch

Attachment 310986 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: LayoutTests/imported/w3c/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 113 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 310991 [details] Patch

Comment on attachment 310991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review > LayoutTests/imported/w3c/resources/import-expectations.json:-65 > - "web-platform-tests/cssom/MediaList.xhtml": "skip", nit: Why this line change ?

Comment on attachment 310991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review >> LayoutTests/imported/w3c/resources/import-expectations.json:-65 >> - "web-platform-tests/cssom/MediaList.xhtml": "skip", > > nit: Why this line change ? That file is updated by the import script, not manually so I prefer to let it do whatever change it wants on it. :-)

Comment on attachment 310991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review > LayoutTests/imported/w3c/ChangeLog:11 > + to reference files there and the importer wasn't able to get them. It is not clear from the title how this gets updated. Isn't it that you are adding web-platform-tests/css/css-grid-1/alignment/ and need to update css/reference? Ideally, you would use the wpt revision in resources/TestRepositories, by doing something like import-w3c-tests web-platform-tests/css/css-grid-1/alignment. >>> LayoutTests/imported/w3c/resources/import-expectations.json:-65 >>> - "web-platform-tests/cssom/MediaList.xhtml": "skip", >> >> nit: Why this line change ? > > That file is updated by the import script, not manually so I prefer to let it do whatever change it wants on it. :-) Yes, this line was added manually but the importer is reordering these.

Comment on attachment 310991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review Thanks for the review. >> LayoutTests/imported/w3c/ChangeLog:11 >> + to reference files there and the importer wasn't able to get them. > > It is not clear from the title how this gets updated. > Isn't it that you are adding web-platform-tests/css/css-grid-1/alignment/ and need to update css/reference? > Ideally, you would use the wpt revision in resources/TestRepositories, by doing something like import-w3c-tests web-platform-tests/css/css-grid-1/alignment. So basically I was downloading the new changes on Grid Layout. In this case it was only that folder that's true. I was using: Tools/Scripts/import-w3c-tests web-platform-tests/css/css-grid-1 -t And at the same time I needed to somehow start importing "css/reference" so I was using: Tools/Scripts/import-w3c-tests web-platform-tests/css/reference -t I'd update the ChangeLog to make it more explicit.

Created attachment 311038 [details] Patch for landing

Comment on attachment 311038 [details] Patch for landing Rejecting attachment 311038 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 311038, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ..1a5e283 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 217288 = d8ecdf893767aa4ac0d2a20b290f74ff2f76350e r217289 = 1a5e28314879dcd6e241ffe89001a24f9d7aa12f Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Total errors found: 0 in 1 files Full output: http://webkit-queues.webkit.org/results/3802009

Created attachment 311041 [details] Rebased patch

I saw some issues with out-of-sync WPT tests. When using the current revision of WPT, it is ok not to mention it. Otherwise, it is good to mention it.

Comment on attachment 311041 [details] Rebased patch Clearing flags on attachment: 311041 Committed r217294: <http://trac.webkit.org/changeset/217294>

All reviewed patches have been landed. Closing bug.