Bug 172237

Created attachment 310428 [details] Patch

Comment on attachment 310428 [details] Patch Attachment 310428 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3764448 New failing tests: fast/forms/number/number-appearance-rtl.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/block/float/032.html fast/forms/input-appearance-spinbutton-up.html fast/forms/input-appearance-spinbutton.html fast/forms/number/number-large-padding.html fast/forms/number/number-spinbutton-in-multi-column.html fast/forms/search-vertical-alignment.html fast/forms/number/number-appearance-spinbutton-layer.html

Created attachment 310436 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 310428 [details] Patch Attachment 310428 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3764521 New failing tests: fast/forms/number/number-appearance-rtl.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/block/float/032.html fast/forms/input-appearance-spinbutton-up.html fast/forms/input-appearance-spinbutton.html fast/forms/number/number-large-padding.html fast/forms/number/number-spinbutton-in-multi-column.html fast/forms/search-vertical-alignment.html fast/forms/number/number-appearance-spinbutton-layer.html

Created attachment 310438 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Comment on attachment 310428 [details] Patch Attachment 310428 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3764473 New failing tests: fast/forms/input-text-word-wrap.html fast/forms/visual-hebrew-text-field.html fast/forms/search-vertical-alignment.html fast/forms/searchfield-heights.html fast/forms/search-rtl.html

Created attachment 310442 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Comment on attachment 310428 [details] Patch Attachment 310428 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3764790 New failing tests: fast/forms/number/number-appearance-rtl.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/block/float/032.html fast/forms/input-appearance-spinbutton-up.html fast/forms/input-appearance-spinbutton.html fast/forms/number/number-large-padding.html fast/forms/number/number-spinbutton-in-multi-column.html fast/forms/search-vertical-alignment.html fast/forms/number/number-appearance-spinbutton-layer.html

Created attachment 310447 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Created attachment 311146 [details] Patch

Attachment 311146 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderTextControlSingleLine.cpp:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311146 [details] Patch Attachment 311146 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3808612 New failing tests: fast/forms/number/number-appearance-rtl.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/forms/input-appearance-spinbutton-up.html fast/forms/input-appearance-spinbutton.html fast/forms/search-vertical-alignment.html fast/forms/number/number-appearance-spinbutton-layer.html

Created attachment 311149 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 311146 [details] Patch Attachment 311146 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3808544 New failing tests: http/tests/cache/cancel-during-revalidation-succeeded.html

Created attachment 311150 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Comment on attachment 311146 [details] Patch Attachment 311146 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3808615 New failing tests: fast/forms/number/number-appearance-rtl.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/forms/input-appearance-spinbutton-up.html fast/forms/input-appearance-spinbutton.html fast/forms/search-vertical-alignment.html fast/forms/number/number-appearance-spinbutton-layer.html

Created attachment 311151 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Created attachment 311152 [details] Patch

Comment on attachment 311146 [details] Patch Attachment 311146 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3808636 New failing tests: fast/forms/number/number-appearance-rtl.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/forms/input-appearance-spinbutton-up.html fast/forms/input-appearance-spinbutton.html fast/forms/search-vertical-alignment.html fast/forms/number/number-appearance-spinbutton-layer.html

Created attachment 311154 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 311152 [details] Patch Attachment 311152 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3808951 New failing tests: fast/events/before-unload-returnValue.html

Created attachment 311161 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Created attachment 311217 [details] Patch

Landed in r217418.

Comment on attachment 311217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311217&action=review > LayoutTests/platform/mac-elcapitan/TestExpectations:6 > +fast/forms/number/number-appearance-rtl.html [ Skip ] > +fast/forms/number/number-appearance-spinbutton-disabled-readonly.html [ Skip ] > +fast/forms/input-appearance-spinbutton-up.html [ Skip ] > +fast/forms/input-appearance-spinbutton.html [ Skip ] > +fast/forms/search-vertical-alignment.html [ Skip ] > +fast/forms/number/number-appearance-spinbutton-layer.html [ Skip ] It's not an accident that this file didn't exist after all these years of El Capitan being available. El Capitan expectations should be in platform/mac/TestExpectations with [ ElCapitan ] modifier.

It's also unclear to me why skipping was appropriate in the first place. Don't we want EWS to keep running these tests?