Bug 171627

Created attachment 308976 [details] Patch v1

Ah, this patch is blocked on the fix for Bug 171510 landing.

Don't we call this --reset-results elsewhere? Or is this different from that?

(In reply to Sam Weinig from comment #3) > Don't we call this --reset-results elsewhere? Or is this different from that? Yes, with run-webkit-tests. Easy enough to change if that's preferred.

(In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to Sam Weinig from comment #3) > > Don't we call this --reset-results elsewhere? Or is this different from that? > > Yes, with run-webkit-tests. Easy enough to change if that's preferred. It's also what we use for run-binding-tests. Yeah, I think it would be better to be consistent.

Created attachment 309035 [details] Patch v2

Created attachment 309036 [details] Patch v3 Same as "Patch v2" but used --patience to create the patch.

Attachment 309036 [details] did not pass style-queue: ERROR: Source/WebKit2/Scripts/webkit/LegacyMessages-expected.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Scripts/webkit/Messages-expected.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

(In reply to Build Bot from comment #8) > Attachment 309036 [details] did not pass style-queue: > > > ERROR: Source/WebKit2/Scripts/webkit/LegacyMessages-expected.h:42: Code > inside a namespace should not be indented. [whitespace/indent] [4] > ERROR: Source/WebKit2/Scripts/webkit/Messages-expected.h:42: Code inside a > namespace should not be indented. [whitespace/indent] [4] > Total errors found: 2 in 8 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This means that the generated code doesn't pass style guidelines.

Comment on attachment 309036 [details] Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=309036&action=review r=me > Source/WebKit2/ChangeLog:8 > + This change adds support for an [-r|--reset-reesults] switch an => a --reset-reesults => --reset-results > Source/WebKit2/ChangeLog:52 > + - Parses [-r|--reset-results] switch, and then remove it from remove => removes > Source/WebKit2/Scripts/webkit/messages_unittest.py:357 > + if arg in ('-r', '--r', '--reset', '--reset-results') or '--reset-results'.startswith(arg): Wow, this is pretty generous parsing. I wish there was a way to make this option discoverable.

Comment on attachment 309036 [details] Patch v3 Attachment 309036 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3672235 New failing tests: fast/dom/Window/setTimeout-no-arguments.html

Created attachment 309042 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

(In reply to Daniel Bates from comment #10) > Comment on attachment 309036 [details] > Patch v3 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309036&action=review > > r=me > > > Source/WebKit2/Scripts/webkit/messages_unittest.py:357 > > + if arg in ('-r', '--r', '--reset', '--reset-results') or '--reset-results'.startswith(arg): > > Wow, this is pretty generous parsing. I wish there was a way to make this > option discoverable. Done in Patch v4! This is what the help output looks like after this change: $ python Source/WebKit2/Scripts/webkit/messages_unittest.py -h Usage: messages_unittest.py [options] [test] [...] Custom Options: -r, --reset-results Reset expected results for messages_unittest.py Options: -h, --help Show this message -v, --verbose Verbose output -q, --quiet Minimal output -f, --failfast Stop on first failure -c, --catch Catch control-C and display results -b, --buffer Buffer stdout and stderr during test runs Examples: messages_unittest.py - run default set of tests messages_unittest.py MyTestSuite - run suite 'MyTestSuite' messages_unittest.py MyTestCase.testSomething - run MyTestCase.testSomething messages_unittest.py MyTestCase - run all 'test*' test methods in MyTestCase

Created attachment 309159 [details] Patch v4 Changes from Patch v3: - Changed use of split('\n') to more canonical split lines(False). - Added add_reset_results_to_unittest_help() to add [-r|--reset-results] switch to help/usage output.

Attachment 309159 [details] did not pass style-queue: ERROR: Source/WebKit2/Scripts/webkit/LegacyMessages-expected.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Scripts/webkit/Messages-expected.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 309161 [details] Patch v5 (to make title be grammatically consistent)

Attachment 309161 [details] did not pass style-queue: ERROR: Source/WebKit2/Scripts/webkit/LegacyMessages-expected.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Scripts/webkit/Messages-expected.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 309161 [details] Patch v5 (to make title be grammatically consistent) Clearing flags on attachment: 309161 Committed r216327: <http://trac.webkit.org/changeset/216327>

All reviewed patches have been landed. Closing bug.