Bug 171491

Summary: [GTK] Two test started to fail after due to unhandled promise rejection reported after r215916
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, joepeck, saam
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=150358
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] For landing none

Carlos Garcia Campos
Reported 2017-05-01 01:27:43 PDT
js/promises-tests/promises-tests-2-3-3.html media/video-fullscreen-restriction-removed.html https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r216004 (842)/js/promises-tests/promises-tests-2-3-3-pretty-diff.html https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r216004 (842)/media/video-fullscreen-restriction-removed-pretty-diff.html Other test expectation were updated to include such message, but I don't know id these test are expected to produce them or not.
Attachments
[PATCH] Proposed Fix (2.14 KB, patch)
2017-05-01 15:50 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] For landing (3.01 KB, patch)
2017-05-01 15:52 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-05-01 01:40:03 PDT
Expectations updated in r216011
Joseph Pecoraro
Comment 2 2017-05-01 14:12:16 PDT
Took me a while to realize those were links! I can address the js/promise-tests one by disabling unhandled rejection warnings. The media/video-fullscreen-restriction-removed.html case can be rebaselined. I'll address these as soon as my follow-up patch gets reviewed (as it affects the output here).
Joseph Pecoraro
Comment 3 2017-05-01 15:46:50 PDT
Looking into this now.
Joseph Pecoraro
Comment 4 2017-05-01 15:50:56 PDT
Created attachment 308778 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 5 2017-05-01 15:51:09 PDT
Err, I have to unskip now.
Joseph Pecoraro
Comment 6 2017-05-01 15:52:11 PDT
Created attachment 308779 [details] [PATCH] For landing
Joseph Pecoraro
Comment 7 2017-05-01 15:53:17 PDT
Comment on attachment 308779 [details] [PATCH] For landing Going to land this unreviewed as gardening.
Joseph Pecoraro
Comment 8 2017-05-01 15:54:47 PDT
<https://trac.webkit.org/changeset/216039> Unskipped and modified the tests/results.
Carlos Garcia Campos
Comment 9 2017-05-02 00:54:40 PDT
Thanks!
Note You need to log in before you can comment on or make changes to this bug.