Bug 171411

Summary: Speedometer: Add an Inferno TodoMVC implementation
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch rniwa: review+, commit-queue: commit-queue-

Addy Osmani
Reported 2017-04-27 18:19:37 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), introduce an Inferno (https://infernojs.org/) implementation of TodoMVC. Similar to Preact, it is another performance-focused alternative to React with a similar API that offers a similar feature set at a smaller size.
Attachments
Patch (170.16 KB, patch)
2017-04-27 18:35 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (162.30 KB, patch)
2017-05-11 18:35 PDT, Addy Osmani 		rniwa: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-27 18:35:26 PDT
Created attachment 308489 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-08 22:55:06 PDT
Comment on attachment 308489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308489&action=review I guess Inferno example doesn't try to restore anything to localStorage in the first place? > PerformanceTests/ChangeLog:7 > + Adds a Inferno implem of TodoMVC to Speedometer Please add a blank line between "Reviewed by" and this line. > PerformanceTests/ChangeLog:10 Please these per-function comments. Since you're not adding any comments, they're only cluttering the change log.
Addy Osmani
Comment 3 2017-05-11 18:35:55 PDT
Created attachment 309842 [details] Patch
Addy Osmani
Comment 4 2017-05-11 18:36:25 PDT
Added a blank line and removed per function comments as requested. PTAL.
WebKit Commit Bot
Comment 5 2017-05-11 19:36:47 PDT
Comment on attachment 309842 [details] Patch Rejecting attachment 309842 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309842, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a48a49823dfb07f4bf990e6356130677633 r216709 = 762031772c38451f69aa1fd7308f0e4ba8a2af21 r216710 = 2d96e9eb3105de5c55e9a3b37102a61b56e717e5 r216711 = e6f5012ae5d3cb699a776fedc2b51eb16f8aa4ec r216712 = bcabe4ed74dbf7146ae1868f3165ab34cd5764fa r216713 = 0f39ca8af1438b885163d4e799cd96825430c98e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3722898
Ryosuke Niwa
Comment 6 2017-05-11 20:00:03 PDT
Committed r216723: <http://trac.webkit.org/changeset/216723>
Note You need to log in before you can comment on or make changes to this bug.