Bug 171343

Summary: Speedometer: Add an Angular 2 (4.x) TodoMVC implementation
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
Patch none

Addy Osmani
Reported 2017-04-26 14:47:21 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), add an implementation of TodoMVC for the benchmark using the new Angular (4.x) - previously more broadly known as Angular 2 (https://angular.io/). The application heavily demonstrates use of TypeScript that gets transpiled back to JS and marks a pattern we think will see increased use in the future and is worth benchmarking. It is distinctly different to the AngularJS implementation of TodoMVC being updated in https://bugs.webkit.org/show_bug.cgi?id=171307 (which is based on 1.x and is still heavily used by a longtail of developers).
Attachments
Patch (490.97 KB, patch)
2017-04-26 14:50 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-elcapitan (1.84 MB, application/zip)
2017-04-26 16:44 PDT, Build Bot 		no flags
Details
Patch (459.46 KB, patch)
2017-05-11 17:49 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-26 14:50:25 PDT
Created attachment 308286 [details] Patch
Build Bot
Comment 2 2017-04-26 16:44:55 PDT
Comment on attachment 308286 [details] Patch Attachment 308286 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3614150 New failing tests: workers/wasm-long-compile-many.html
Build Bot
Comment 3 2017-04-26 16:44:57 PDT
Created attachment 308307 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Ryosuke Niwa
Comment 4 2017-05-08 22:58:50 PDT
Comment on attachment 308286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308286&action=review Hm... Angular version doesn't use localStorage anymore these days? I guess it works better for us. > PerformanceTests/ChangeLog:7 > + Add a TodoMVC Angular 2 (4.x) implem for the benchmark Please add a blank line between reviewed-by line and this comment. > PerformanceTests/ChangeLog:13 > + (html,): Please remove these per-style rule and per-function comments since we're not adding inline comments for them, and we're just importing from elsewhere.
Addy Osmani
Comment 5 2017-05-11 17:49:38 PDT
Created attachment 309835 [details] Patch
Addy Osmani
Comment 6 2017-05-11 17:50:18 PDT
Added a blank line between the reviewed-by and the comment. Also removed per style rule and per function comments as requested. PTAL.
Ryosuke Niwa
Comment 7 2017-05-11 19:55:40 PDT
Comment on attachment 309835 [details] Patch Clearing flags on attachment: 309835 Committed r216721: <http://trac.webkit.org/changeset/216721>
Ryosuke Niwa
Comment 8 2017-05-11 19:55:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.