Bug 171306

Summary: Speedometer: Update the vanilla JavaScript TodoMVC implem to a more recent version
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch none

Addy Osmani
Reported 2017-04-25 18:24:15 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), the vanilla JavaScript implementation of TodoMVC needs to be updated to a more recent version.
Attachments
Patch (98.65 KB, patch)
2017-04-26 08:12 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (93.48 KB, patch)
2017-05-11 17:37 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-26 08:12:13 PDT
Created attachment 308247 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-09 14:38:59 PDT
Comment on attachment 308247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308247&action=review > PerformanceTests/ChangeLog:7 > + Update vanilla JS TodoMVC implementation to the latest. Please add a blank line above this. > PerformanceTests/ChangeLog:95 > + (html,): Please remove these per-rule comments since we're just importing a file.
Addy Osmani
Comment 3 2017-05-11 17:37:28 PDT
Created attachment 309834 [details] Patch
Addy Osmani
Comment 4 2017-05-11 17:40:26 PDT
Added a line above and removed per-rule comments. PTAL.
Ryosuke Niwa
Comment 5 2017-05-11 19:53:58 PDT
Comment on attachment 309834 [details] Patch Clearing flags on attachment: 309834 Committed r216719: <http://trac.webkit.org/changeset/216719>
Ryosuke Niwa
Comment 6 2017-05-11 19:53:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.