Bug 171305

Summary: Speedometer: Update the Backbone.js implementation to a more recent library version
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch none

Addy Osmani
Reported 2017-04-25 18:18:43 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), the Backbone.js implementation of TodoMVC needs to be updated to a more recent version.
Attachments
Patch (953.12 KB, patch)
2017-04-25 18:21 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (929.18 KB, patch)
2017-05-11 18:12 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-25 18:21:24 PDT
Created attachment 308181 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-09 14:50:49 PDT
Comment on attachment 308181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308181&action=review > PerformanceTests/ChangeLog:7 > + Updates the Backbone.js TodoMVC implementation to latest Add a blink line above this. > PerformanceTests/ChangeLog:52 > + (else): Are these functions modified? If not, we should just get rid of these inline comments. > PerformanceTests/ChangeLog:128 > + (typeof.module.string_appeared_here.typeof.module.exports.string_appeared_here.true): Please remove these inline comments if files are simply imported from somewhere.
Addy Osmani
Comment 3 2017-05-11 18:12:49 PDT
Created attachment 309839 [details] Patch
Addy Osmani
Comment 4 2017-05-11 18:13:10 PDT
Added a blank line above the title and removed inline comments. PTAL.
WebKit Commit Bot
Comment 5 2017-05-11 19:40:28 PDT
Comment on attachment 309839 [details] Patch Rejecting attachment 309839 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309839, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a48a49823dfb07f4bf990e6356130677633 r216709 = 762031772c38451f69aa1fd7308f0e4ba8a2af21 r216710 = 2d96e9eb3105de5c55e9a3b37102a61b56e717e5 r216711 = e6f5012ae5d3cb699a776fedc2b51eb16f8aa4ec r216712 = bcabe4ed74dbf7146ae1868f3165ab34cd5764fa r216713 = 0f39ca8af1438b885163d4e799cd96825430c98e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3722934
Ryosuke Niwa
Comment 6 2017-05-11 19:46:52 PDT
Comment on attachment 309839 [details] Patch Clearing flags on attachment: 309839 Committed r216716: <http://trac.webkit.org/changeset/216716>
Ryosuke Niwa
Comment 7 2017-05-11 19:46:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.