Bug 171115

Summary: [cmake] WTF target should not have wtf and subdirectries in public interface
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167343
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2017-04-21 09:09:54 PDT
In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of targets as their public interface, so that linked targets can use them implicitly without copying directory lists around. This matches existing practice for all targets except WTF, headers from which are always included with full path starting from "<wtf/...". Since r209665 it became possible to include headers from wtf or its subdirectories in CMake builds without using "<wtf/..." path. It should not be allowed.
Attachments
Patch (5.84 KB, patch)
2017-04-21 09:11 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-04-21 09:11:43 PDT
Created attachment 307735 [details] Patch
Konstantin Tokarev
Comment 2 2017-04-21 10:26:09 PDT
Comment on attachment 307735 [details] Patch Clearing flags on attachment: 307735 Committed r215614: <http://trac.webkit.org/changeset/215614>
Konstantin Tokarev
Comment 3 2017-04-21 10:26:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.