Bug 17098
| Summary: | Replace our broken KURL with Google URL | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | abarth, achristensen, ap, brettw, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| URL: | http://code.google.com/p/google-url/ | ||
| Bug Depends on: | |||
| Bug Blocks: | 37641 | ||
Eric Seidel (no email)
Replace our broken KURL with Google URL
Google wrote its own URL parsing library which is used a bunch internally, and looks to be significantly better than KURL. If nothing else, the several hundred unit tests are useful. I don't think KURL even does any cannonicalization (which gurl does).
http://code.google.com/p/google-url/
I think WebKit should just pull in gurl as a dependency. The google coding style is kinda strange, but generally pretty similar to WebKit's own. It might even be published somewhere externally...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
bug 16799 is an example where (in complex cases) we would require a url parser which could canonicalize urls.
Brett Wilson (Google)
A pet peeve of mine is that a link to "Apple.com" will not be marked as visited, because the URL is not canonicalized before Safari does a history lookup.
Alexey Proskuryakov
Our URL class is very different now from what it was in 2008.