Bug 170081

Summary: Tighten RTCDatachannel creation and parameter getters
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, jonlee
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 169662    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2017-03-24 15:58:35 PDT
Tighten RTCDatachannel creation and parameter getters
Attachments
Patch (15.31 KB, patch)
2017-03-24 16:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.22 KB, patch)
2017-03-27 10:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-03-24 16:00:47 PDT
Created attachment 305330 [details] Patch
Eric Carlson
Comment 2 2017-03-24 16:24:23 PDT
Comment on attachment 305330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305330&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:335 > + if (options.negotiated && !options.negotiated.value() && (label.length() > 65535 || options.protocol.length() > 65535)) USHRT_MAX? > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:341 > + if (options.id && options.id.value() > 65534) ">= USHRT_MAX"? If not, a named constant would be nice to make it obvious what this limit represents.
Eric Carlson
Comment 3 2017-03-24 16:24:47 PDT
Comment on attachment 305330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305330&action=review > LayoutTests/webrtc/datachannel/basic.html:203 > + > + Nit: extra blank line.
youenn fablet
Comment 4 2017-03-24 16:51:41 PDT
Thanks for the review. The values are literally from the spec, I am not sure it is worth moving away from the spec
youenn fablet
Comment 5 2017-03-27 10:30:16 PDT
Created attachment 305481 [details] Patch for landing
youenn fablet
Comment 6 2017-03-27 10:30:51 PDT
Thanks for the review. (In reply to Eric Carlson from comment #3) > Comment on attachment 305330 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305330&action=review > > > LayoutTests/webrtc/datachannel/basic.html:203 > > + > > + > > Nit: extra blank line. Done
WebKit Commit Bot
Comment 7 2017-03-27 11:13:23 PDT
Comment on attachment 305481 [details] Patch for landing Clearing flags on attachment: 305481 Committed r214421: <http://trac.webkit.org/changeset/214421>
WebKit Commit Bot
Comment 8 2017-03-27 11:13:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.