Bug 169644

Summary: Add support for RTCPeerConnection.onicecandidateerror event
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebKit Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, aperez, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, magomez, philipj, ryuan.choi, sergio, solmaks, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173118    
Bug Blocks: 169662    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Jon Lee
Reported 2017-03-14 16:51:36 PDT
Update RTCPeerConnection IDL
Attachments
Patch (25.64 KB, patch)
2020-11-19 06:53 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (27.31 KB, patch)
2020-11-19 08:21 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (38.84 KB, patch)
2020-11-19 11:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (38.86 KB, patch)
2020-11-20 00:33 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (38.86 KB, patch)
2020-11-20 01:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-11-19 06:53:26 PST
Created attachment 414574 [details] Patch
youenn fablet
Comment 2 2020-11-19 08:21:38 PST
Created attachment 414582 [details] Patch
youenn fablet
Comment 3 2020-11-19 11:24:51 PST
Created attachment 414605 [details] Patch
Alex Christensen
Comment 4 2020-11-19 11:50:20 PST
Comment on attachment 414605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414605&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357 > + if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) { It seems strange to me to be using path for host-like things here, but that's how it works. > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46 > + uint16_t errorCode; May as well add { 0 } to prevent use of uninitialized memory. > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67 > + uint16_t m_errorCode; ditto
youenn fablet
Comment 5 2020-11-20 00:31:05 PST
Thanks for the review. (In reply to Alex Christensen from comment #4) > Comment on attachment 414605 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414605&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357 > > + if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) { > > It seems strange to me to be using path for host-like things here, but > that's how it works. Right, though the good thing is that we do not start thinking this URL has an origin. > > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46 > > + uint16_t errorCode; > > May as well add { 0 } to prevent use of uninitialized memory. > > > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67 > > + uint16_t m_errorCode; > > ditto OK
youenn fablet
Comment 6 2020-11-20 00:33:41 PST
Created attachment 414657 [details] Patch for landing
EWS
Comment 7 2020-11-20 00:47:40 PST
ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.
youenn fablet
Comment 8 2020-11-20 01:07:51 PST
Created attachment 414662 [details] Patch for landing
EWS
Comment 9 2020-11-20 03:05:56 PST
Committed r270101: <https://trac.webkit.org/changeset/270101> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414662 [details].
Radar WebKit Bug Importer
Comment 10 2020-11-20 03:06:22 PST
<rdar://problem/71621717>
Brent Fulgham
Comment 11 2022-06-30 16:37:34 PDT
*** Bug 199207 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.