Bug 168847

Summary: [css-align] Implement the place-items shorthand
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: CSSAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, darin, hyatt, jfernandez, jonlee, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=668639
Bug Depends on:    
Bug Blocks: 168845    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Javier Fernandez
Reported 2017-02-24 14:33:08 PST
Spec: https://drafts.csswg.org/css-align/#place-items-property Note that the syntax has just been discussed on the CSS WG. Check the last comments on this issue before implementing them: https://github.com/w3c/csswg-drafts/issues/595#issuecomment-262709407
Attachments
Patch (23.65 KB, patch)
2017-04-05 01:20 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (23.66 KB, patch)
2017-04-05 01:39 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (23.66 KB, patch)
2017-04-05 02:37 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2017-04-05 01:20:55 PDT
Created attachment 306269 [details] Patch
Javier Fernandez
Comment 2 2017-04-05 01:39:43 PDT
Created attachment 306272 [details] Patch Fixed build errors.
Javier Fernandez
Comment 3 2017-04-05 02:37:05 PDT
Created attachment 306276 [details] Patch Fixed layout tests errors.
Dave Hyatt
Comment 4 2017-04-05 13:08:34 PDT
Comment on attachment 306276 [details] Patch r=me
WebKit Commit Bot
Comment 5 2017-04-05 13:44:14 PDT
Comment on attachment 306276 [details] Patch Clearing flags on attachment: 306276 Committed r214966: <http://trac.webkit.org/changeset/214966>
WebKit Commit Bot
Comment 6 2017-04-05 13:44:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.