Bug 168846

Summary:

[css-align] Implement the place-self shorthand

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, darin, hyatt, jfernandez, jonlee, rego, rniwa, svillar, zalan

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

168845

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none

Javier Fernandez

Reported 2017-02-24 14:32:25 PST

Spec: https://drafts.csswg.org/css-align/#place-self-property Note that the syntax has just been discussed on the CSS WG. Check the last comments on this issue before implementing them: https://github.com/w3c/csswg-drafts/issues/595#issuecomment-262709407

Attachments
Patch (20.59 KB, patch) 2017-05-05 06:50 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (20.58 KB, patch) 2017-05-05 07:48 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (751.52 KB, application/zip) 2017-05-05 09:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (841.03 KB, application/zip) 2017-05-05 09:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.77 MB, application/zip) 2017-05-05 09:17 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (916.01 KB, application/zip) 2017-05-05 09:31 PDT, Build Bot	no flags	Details
Patch (20.25 KB, patch) 2017-05-10 05:05 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2017-05-05 06:50:41 PDT

Created attachment 309167 [details] Patch

Javier Fernandez

Comment 2 2017-05-05 07:48:17 PDT

Created attachment 309168 [details] Patch

Build Bot

Comment 3 2017-05-05 09:02:48 PDT

Comment on attachment 309168 [details] Patch Attachment 309168 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3679472 New failing tests: css3/parse-place-self.html

Build Bot

Comment 4 2017-05-05 09:02:50 PDT

Created attachment 309171 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-05-05 09:08:29 PDT

Comment on attachment 309168 [details] Patch Attachment 309168 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3679478 New failing tests: css3/parse-place-self.html

Build Bot

Comment 6 2017-05-05 09:08:30 PDT

Created attachment 309172 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-05-05 09:17:48 PDT

Comment on attachment 309168 [details] Patch Attachment 309168 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3679481 New failing tests: css3/parse-place-self.html

Build Bot

Comment 8 2017-05-05 09:17:50 PDT

Created attachment 309174 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-05-05 09:31:00 PDT

Comment on attachment 309168 [details] Patch Attachment 309168 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3679499 New failing tests: css3/parse-place-self.html

Build Bot

Comment 10 2017-05-05 09:31:02 PDT

Created attachment 309177 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Javier Fernandez

Comment 11 2017-05-10 05:05:44 PDT

Created attachment 309590 [details] Patch

WebKit Commit Bot

Comment 12 2017-05-13 14:37:02 PDT

Comment on attachment 309590 [details] Patch Clearing flags on attachment: 309590 Committed r216829: <http://trac.webkit.org/changeset/216829>

WebKit Commit Bot

Comment 13 2017-05-13 14:37:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.