Bug 168788

Summary: WebAssembly: stop supporting 0xD
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, funnyjokes1.com, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 168672    
Bug Blocks: 159775    
Attachments:
Description Flags
patch
saam: review+, saam: commit-queue-
patch
jfbastien: commit-queue+
patch none

JF Bastien
Reported 2017-02-23 11:02:19 PST
As a temporary measure in bug #168672 I left support for 0xD in the decoder because not all the tooling and demos support it. Remove it at some point in time.
Attachments
patch (3.60 KB, patch)
2017-05-11 00:17 PDT, JF Bastien 		saam: review+
saam: commit-queue-
DetailsFormatted DiffDiff
patch (3.52 KB, patch)
2017-05-11 00:26 PDT, JF Bastien 		jfbastien: commit-queue+
DetailsFormatted DiffDiff
patch (3.51 KB, patch)
2017-05-11 00:27 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-27 22:16:10 PDT
<rdar://problem/31880922>
JF Bastien
Comment 2 2017-05-11 00:17:15 PDT
Created attachment 309696 [details] patch
Saam Barati
Comment 3 2017-05-11 00:23:42 PDT
Comment on attachment 309696 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=309696&action=review > Source/JavaScriptCore/wasm/WasmModuleParser.cpp:1 > + Remove this please
JF Bastien
Comment 4 2017-05-11 00:26:04 PDT
Created attachment 309697 [details] patch
JF Bastien
Comment 5 2017-05-11 00:26:29 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 309696 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309696&action=review > > > Source/JavaScriptCore/wasm/WasmModuleParser.cpp:1 > > + > > Remove this please Oops how did I do that.
JF Bastien
Comment 6 2017-05-11 00:27:30 PDT
Created attachment 309698 [details] patch Fix oops.
WebKit Commit Bot
Comment 7 2017-05-11 00:56:36 PDT
Comment on attachment 309698 [details] patch Clearing flags on attachment: 309698 Committed r216672: <http://trac.webkit.org/changeset/216672>
WebKit Commit Bot
Comment 8 2017-05-11 00:56:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.