Bug 168755

Summary: [Modern Media Controls] Clicking on the video doesn't toggle playback state in fullscreen on macOS
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168515
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2017-02-22 16:44:14 PST
We added support for clicking on the video to toggle playback on macOS with https://bugs.webkit.org/show_bug.cgi?id=168515, but it doesn't work in fullscreen.
Attachments
Patch (9.89 KB, patch)
2017-02-22 17:54 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-22 16:45:15 PST
<rdar://problem/30664484>
Antoine Quint
Comment 2 2017-02-22 17:54:11 PST
Created attachment 302472 [details] Patch
WebKit Commit Bot
Comment 3 2017-02-22 18:55:53 PST
The commit-queue encountered the following flaky tests while processing attachment 302472 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2017-02-22 18:56:12 PST
The commit-queue encountered the following flaky tests while processing attachment 302472 [details]: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-02-22 18:57:47 PST
Comment on attachment 302472 [details] Patch Clearing flags on attachment: 302472 Committed r212872: <http://trac.webkit.org/changeset/212872>
WebKit Commit Bot
Comment 6 2017-02-22 18:57:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.