Bug 168515

Summary:

[Modern Media Controls] Toggle playback when clicking on the video on macOS

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=168755

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	dino: review+

Antoine Quint

Reported 2017-02-17 07:51:58 PST

We should toggle playback when clicking on the video on macOS

Attachments
Patch (18.99 KB, patch) 2017-02-17 08:32 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (14.97 MB, application/zip) 2017-02-17 09:49 PST, Build Bot	no flags	Details
Patch (19.00 KB, patch) 2017-02-17 11:31 PST, Antoine Quint	dino: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-02-17 07:54:17 PST

<rdar://problem/30577441>

Antoine Quint

Comment 2 2017-02-17 08:32:09 PST

Created attachment 301934 [details] Patch

Build Bot

Comment 3 2017-02-17 09:49:23 PST

Comment on attachment 301934 [details] Patch Attachment 301934 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3143858 New failing tests: media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html

Build Bot

Comment 4 2017-02-17 09:49:26 PST

Created attachment 301947 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antoine Quint

Comment 5 2017-02-17 11:31:07 PST

Created attachment 301963 [details] Patch

Dean Jackson

Comment 6 2017-02-17 11:57:59 PST

Comment on attachment 301963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301963&action=review > Source/WebCore/ChangeLog:12 > + We now listen to "click" events on the media controls on macOS, and should no > + other element further down in the controls hierarchy receive that event, we > + inform the delegate, in this case the MediaController, that the background > + of the controls was clicked and we toggle playback. This sentence is too long or has too many side notes/comments. How about Listen to click events on the macOS media controls. Detect any clicks that were on the background instead of the controls widgets themselves, and tell the delegate (MediaController) about them. > Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.js:71 > + // Only notify that the background was clicked when the "mousedown" event > + // was also received, which wouldn not happen if the "mousedown" event caused > + // the tracks panel to be hidden. Typo: wouldn't Maybe you should say: // In order to call the delegate for a click, we need to make sure that we've seen a mousedown event first. e.g. when...tracks panel... > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:102 > + // Toggle playback when clickig on the video but not on any controls on macOS. Typo: clicking

Antoine Quint

Comment 7 2017-02-17 13:42:29 PST

Committed r212573: <http://trac.webkit.org/changeset/212573>

Note You need to log in before you can comment on or make changes to this bug.