Bug 167243

Summary: [WebRTC] Update libwertc AudioRtpSender::SetAudioSend
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan none

youenn fablet
Reported 2017-01-20 10:44:10 PST
Disable the static_cast like done for WEBRTC_CHROMIUM_BUILD
Attachments
Patch (1.48 KB, patch)
2017-01-20 10:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.61 KB, patch)
2017-01-20 11:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan (726.26 KB, application/zip)
2017-01-20 12:59 PST, WebKit Commit Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-01-20 10:48:40 PST
Created attachment 299356 [details] Patch
Alex Christensen
Comment 2 2017-01-20 11:08:57 PST
Comment on attachment 299356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299356&action=review > Source/ThirdParty/libwebrtc/ChangeLog:3 > + [WebRTC] Update libwertc AudioRtpSender::SetAudioSend This title doesn't say what is actually happening in the patch. "Add WEBRTC_WEBKIT_BUILD macro to match existing WEBRTC_CHROMIUM_BUILD" would be a better title. Also, do we need to define WEBRTC_WEBKIT_BUILD anywhere, or is that already done?
youenn fablet
Comment 3 2017-01-20 11:21:43 PST
(In reply to comment #2) > Comment on attachment 299356 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299356&action=review > > > Source/ThirdParty/libwebrtc/ChangeLog:3 > > + [WebRTC] Update libwertc AudioRtpSender::SetAudioSend > > This title doesn't say what is actually happening in the patch. > "Add WEBRTC_WEBKIT_BUILD macro to match existing WEBRTC_CHROMIUM_BUILD" > would be a better title. OK. There are other places where WEBRTC_CHROMIUM_BUILD is used but I have not updated them yet. > Also, do we need to define WEBRTC_WEBKIT_BUILD anywhere, or is that already > done? It is defined in Source/ThirdParty/libwebrtc/CMakeLists.txt and added in Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py
youenn fablet
Comment 4 2017-01-20 11:58:30 PST
Created attachment 299363 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-01-20 12:59:05 PST
Comment on attachment 299363 [details] Patch for landing Rejecting attachment 299363 [details] from commit-queue. New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html Full output: http://webkit-queues.webkit.org/results/2921649
WebKit Commit Bot
Comment 6 2017-01-20 12:59:07 PST
Created attachment 299369 [details] Archive of layout-test-results from webkit-cq-02 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 7 2017-01-20 13:25:54 PST
The commit-queue encountered the following flaky tests while processing attachment 299363 [details]: media/audio-concurrent-supported.html bug 167251 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2017-01-20 13:26:21 PST
Comment on attachment 299363 [details] Patch for landing Clearing flags on attachment: 299363 Committed r210977: <http://trac.webkit.org/changeset/210977>
WebKit Commit Bot
Comment 9 2017-01-20 13:26:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.