Bug 167072

<rdar://problem/30033496>

Created attachment 300165 [details] Patch

Comment on attachment 300165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300165&action=review > Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:123 > + continue; This prevents the Search tab from being shown when performing a search while another tab is showing: 1. Goto daringfireball.net 2. Show Network tab 3. Enter "fire" in search field, press Enter Expected: => Taken to search tab, first result selected Actual: => Network tab content view changes, tab does not (see trace). [Log] Trace bestTabContentViewForRepresentedObject (TabBrowser.js:123) tabContentViewForRepresentedObject (Main.js:1138) showRepresentedObject (Main.js:1157) showSourceCode (Main.js:1203) showOriginalOrFormattedSourceCodeTextRange (Main.js:1224) _treeSelectionDidChange (SearchSidebarPanel.js:371) dispatch (Object.js:170) dispatchEventToListeners (Object.js:177) select (TreeElement.js:507) _contentTreeOutlineDidFocus (NavigationSidebarPanel.js:667) focus select (TreeElement.js:476) revealAndSelect (TreeElement.js:516) (anonymous function) (SearchSidebarPanel.js:154) (anonymous function) forEachMatch (SearchSidebarPanel.js:120) resourceCallback (SearchSidebarPanel.js:149) resourceCallback _dispatchResponseToCallback (Connection.js:146) _dispatchResponse (Connection.js:116) dispatch (Connection.js:69) dispatch (InspectorBackend.js:154) dispatchNextQueuedMessageFromBackend (MessageDispatcher.js:42)

Created attachment 300283 [details] Patch

Created attachment 300302 [details] Patch

Comment on attachment 300302 [details] Patch Attachment 300302 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2985322 New failing tests: css3/filters/backdrop/dynamic-with-clip-path.html

Created attachment 300322 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Comment on attachment 300302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300302&action=review > Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js:93 > + ondblclick(event) > + { > + const options = {ignoreSearchTab: true}; > + if (this.representedObject instanceof WebInspector.DOMSearchMatchObject) > + WebInspector.showMainFrameDOMTree(this.representedObject.domNode, options); > + else if (this.representedObject instanceof WebInspector.SourceCodeSearchMatchObject) > + WebInspector.showOriginalOrFormattedSourceCodeTextRange(this.representedObject.sourceCodeTextRange, options); > + } This code makes more sense in a controller class, like we do for single click (selected) events. > Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:123 > + if (options.ignoreSearchTab && tabContentView instanceof WebInspector.SearchTabContentView) > + continue; Maybe instead of ignoreSearchTab, ignoreCurrentTab? Though I think ignoreSearchTab is useful too. So this is fine as-is.

Comment on attachment 300302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300302&action=review >> Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js:93 >> + } > > This code makes more sense in a controller class, like we do for single click (selected) events. So I've seen code go both ways for something like this (e.g. contextmenu items for "Reveal in Resources Tab"). Are you suggesting that I propagate this event to the controller (via some event listener or delegate), which is SearchSidebarPanel in this case? To me, that seems more complex that this solution.

Created attachment 300356 [details] Patch

Comment on attachment 300356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300356&action=review > Source/WebInspectorUI/UserInterface/Views/TreeElement.js:318 > + element.treeElement.dispatchEventToListeners(WebInspector.TreeElement.Event.DoubleClick); This should prevent the double click to expand code that is above, if the event prevents default, like ondblclick does.

Created attachment 300463 [details] Patch

Comment on attachment 300463 [details] Patch Clearing flags on attachment: 300463 Committed r211608: <http://trac.webkit.org/changeset/211608>

All reviewed patches have been landed. Closing bug.