Bug 165902

Summary: Fix 64-bit shift family Wasm opcodes
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfbastien, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Keith Miller
Reported 2016-12-15 10:14:04 PST
Fix 64-bit shift family Wasm opcodes
Attachments
Patch (18.56 KB, patch)
2016-12-15 10:20 PST, Keith Miller 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-15 10:20:23 PST
Created attachment 297198 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-15 10:21:32 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Geoffrey Garen
Comment 3 2016-12-15 10:22:38 PST
Comment on attachment 297198 [details] Patch r=me
JF Bastien
Comment 4 2016-12-15 10:25:49 PST
Comment on attachment 297198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297198&action=review > JSTests/wasm/function-tests/rotl.js:22 > + .End() It should be a validation error to export a function with i64. Why does this pass?
JF Bastien
Comment 5 2016-12-15 10:26:54 PST
You could test the i64 stuff by doing i32 -ext-> i64, and then using the ops. Pass in 2 xx i32 from JS, or them together.
Keith Miller
Comment 6 2016-12-15 11:16:35 PST
Comment on attachment 297198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297198&action=review >> JSTests/wasm/function-tests/rotl.js:22 >> + .End() > > It should be a validation error to export a function with i64. Why does this pass? I don't think this is true. You just can't call (from JS) an exported function that takes/returns an i64.
Keith Miller
Comment 7 2016-12-15 11:17:43 PST
Committed r209866: <http://trac.webkit.org/changeset/209866>
Note You need to log in before you can comment on or make changes to this bug.