Bug 165723

Summary:

[WebCrypto] Import imported/w3c/web-platform-tests/WebCryptoAPI tests

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, cdumez, jiewen_tan, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

160880

Bug Blocks:

Attachments:

Description	Flags
Patch	youennf: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch for landing	buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch for landing	buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-elcapitan	none
Patch for landing	none

Jiewen Tan

Reported 2016-12-10 02:23:46 PST

The test suite has been updated by the working group. We should pull the newest test suite and see how well our new implementation against it.

Attachments
Patch (9.96 MB, patch) 2017-02-08 17:49 PST, Jiewen Tan	youennf: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.25 MB, application/zip) 2017-02-08 18:53 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-elcapitan (780.46 KB, application/zip) 2017-02-08 19:04 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.10 MB, application/zip) 2017-02-08 19:21 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.95 MB, application/zip) 2017-02-08 19:26 PST, Build Bot	no flags	Details
Patch for landing (9.96 MB, patch) 2017-02-09 11:22 PST, Jiewen Tan	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.07 MB, application/zip) 2017-02-09 12:28 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-elcapitan (994.23 KB, application/zip) 2017-02-09 12:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.80 MB, application/zip) 2017-02-09 12:46 PST, Build Bot	no flags	Details
Patch for landing (9.96 MB, patch) 2017-02-09 13:34 PST, Jiewen Tan	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.81 MB, application/zip) 2017-02-09 14:42 PST, Build Bot	no flags	Details
Patch for landing (9.96 MB, patch) 2017-02-09 17:01 PST, Jiewen Tan	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-02-08 15:36:57 PST

<rdar://problem/30430974>

Jiewen Tan

Comment 2 2017-02-08 17:49:54 PST

Created attachment 300991 [details] Patch

youenn fablet

Comment 3 2017-02-08 18:13:26 PST

Comment on attachment 300991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300991&action=review > LayoutTests/TestExpectations:931 > +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html [ Slow ] If these are marked as slow in tests-options.json, you should not need to add these lines. Please remove them if that is the case. If they are not added to tests-options.json, it means that these tests are missing a <meta name=timeout content=long>, assuming they take some time. It would be nice to make a PR to WPT repository to add that info. > LayoutTests/TestExpectations:939 > +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html [ Skip ] It is ok I guess. Out of curiosity, why skipping them?

Build Bot

Comment 4 2017-02-08 18:53:13 PST

Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3028915 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html

Build Bot

Comment 5 2017-02-08 18:53:17 PST

Created attachment 300995 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-02-08 19:04:10 PST

Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3029086 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html

Build Bot

Comment 7 2017-02-08 19:04:14 PST

Created attachment 300996 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-02-08 19:21:03 PST

Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3029029 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.html

Build Bot

Comment 9 2017-02-08 19:21:06 PST

Created attachment 300999 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2017-02-08 19:26:02 PST

Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3029049 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.html

Build Bot

Comment 11 2017-02-08 19:26:05 PST

Created attachment 301000 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jiewen Tan

Comment 12 2017-02-09 11:09:50 PST

Comment on attachment 300991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300991&action=review Thanks Youenn for r+ my patch. >> LayoutTests/TestExpectations:931 >> +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html [ Slow ] > > If these are marked as slow in tests-options.json, you should not need to add these lines. > Please remove them if that is the case. > > If they are not added to tests-options.json, it means that these tests are missing a <meta name=timeout content=long>, assuming they take some time. > It would be nice to make a PR to WPT repository to add that info. Remove test_successes_RSA-OAEP.html and test_successes_RSASSA-PKCS1-v1_5.html. For successes_RSA-OAEP.worker.html and successes_RSASSA-PKCS1-v1_5.worker.html, it is generated by us. Therefore, keep them. >> LayoutTests/TestExpectations:939 >> +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html [ Skip ] > > It is ok I guess. Out of curiosity, why skipping them? These test cases are a superset of all the test_successes* tests. Therefore, there is no need to run them since we run all the subsets.

Jiewen Tan

Comment 13 2017-02-09 11:22:41 PST

Created attachment 301059 [details] Patch for landing

Chris Dumez

Comment 14 2017-02-09 11:25:08 PST

Note that I updated testharness.js last night so your tests may need rebaselining.

Jiewen Tan

Comment 15 2017-02-09 11:28:19 PST

(In reply to comment #14) > Note that I updated testharness.js last night so your tests may need > rebaselining. Thanks for your information.

Build Bot

Comment 16 2017-02-09 12:27:56 PST

Comment on attachment 301059 [details] Patch for landing Attachment 301059 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3051409 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html

Build Bot

Comment 17 2017-02-09 12:28:00 PST

Created attachment 301071 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 18 2017-02-09 12:35:52 PST

Comment on attachment 301059 [details] Patch for landing Attachment 301059 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3051469 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html

Build Bot

Comment 19 2017-02-09 12:35:56 PST

Created attachment 301072 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 20 2017-02-09 12:46:38 PST

Comment on attachment 301059 [details] Patch for landing Attachment 301059 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3051458 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html

Build Bot

Comment 21 2017-02-09 12:46:43 PST

Created attachment 301074 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jiewen Tan

Comment 22 2017-02-09 13:34:32 PST

Created attachment 301076 [details] Patch for landing

Build Bot

Comment 23 2017-02-09 14:42:44 PST

Comment on attachment 301076 [details] Patch for landing Attachment 301076 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3052531 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker.html

Build Bot

Comment 24 2017-02-09 14:42:49 PST

Created attachment 301088 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jiewen Tan

Comment 25 2017-02-09 17:01:20 PST

Created attachment 301104 [details] Patch for landing

Jiewen Tan

Comment 26 2017-02-10 10:22:59 PST

Committed r212124: <http://trac.webkit.org/changeset/212124>

Note You need to log in before you can comment on or make changes to this bug.