Bug 165345

Summary:

WebAssembly: update binary format to 0xD version

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

JavaScriptCore

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jfbastien, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

164724, 165308, 165335

Bug Blocks:

159775

Attachments:

Description	Flags
patch	none

JF Bastien

Reported 2016-12-02 15:39:21 PST

Re-land: https://bugs.webkit.org/show_bug.cgi?id=164724 Rolled back in: https://bugs.webkit.org/show_bug.cgi?id=165308 Root cause fixed in: https://bugs.webkit.org/show_bug.cgi?id=165335

Attachments
patch (179.46 KB, patch) 2016-12-03 14:11 PST, JF Bastien	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

JF Bastien

Comment 1 2016-12-03 14:11:50 PST

Created attachment 296068 [details] patch It looks like everything should build now! This is the same as the previous 0xD patch, except it merges in new instructions which Keith added in the meantime.

WebKit Commit Bot

Comment 2 2016-12-03 14:14:15 PST

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

Keith Miller

Comment 3 2016-12-03 14:33:59 PST

Comment on attachment 296068 [details] patch r=me.

WebKit Commit Bot

Comment 4 2016-12-03 14:58:50 PST

Comment on attachment 296068 [details] patch Clearing flags on attachment: 296068 Committed r209306: <http://trac.webkit.org/changeset/209306>

WebKit Commit Bot

Comment 5 2016-12-03 14:58:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.