Bug 164571

Summary: LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163636
https://bugs.webkit.org/show_bug.cgi?id=165346
Bug Depends on:    
Bug Blocks: 164784    
Attachments:
Description Flags
Patch
none
Patch for landing none

Ryan Haddad
Reported 2016-11-09 17:00:57 PST
LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r208491%20(9320)/results.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-actual.txt @@ -8,8 +8,14 @@ PASS mediaController.controls.height is 240 Resizing to 400x300 -PASS mediaController.controls.width is 400 -PASS mediaController.controls.height is 300 +FAIL mediaController.controls.width should be 400. Was 320. +FAIL mediaController.controls.height should be 300. Was 240. + +PASS successfullyParsed is true + +TEST COMPLETE +FAIL mediaController.controls.width should be 400. Was 0. +FAIL mediaController.controls.height should be 300. Was 0. PASS successfullyParsed is true
Attachments
Patch (1.57 KB, patch)
2017-02-02 05:23 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.57 KB, patch)
2017-02-02 05:25 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-11-09 17:25:11 PST
Marked as flaky (or rather, added failure to the list) in http://trac.webkit.org/projects/webkit/changeset/208512
Ryan Haddad
Comment 2 2016-12-05 09:47:44 PST
Flaky expectation was removed as part of http://trac.webkit.org/projects/webkit/changeset/209291, but the test is still a flaky failure.
Ryan Haddad
Comment 3 2016-12-05 09:50:47 PST
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r209315%20(10107)/media/modern-media-controls/media-controller/media-controller-resize-diff.txt --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-actual.txt @@ -4,14 +4,14 @@ Checking initial size -PASS mediaControls.style.width is "320px" -PASS mediaControls.style.height is "240px" +FAIL mediaControls.style.width should be 320px. Was . +FAIL mediaControls.style.height should be 240px. Was . Resizing to 400x300 Shadow root received a resize event -PASS mediaControls.style.width is "400px" -PASS mediaControls.style.height is "300px" +FAIL mediaControls.style.width should be 400px. Was . +FAIL mediaControls.style.height should be 300px. Was . PASS successfullyParsed is true
Ryan Haddad
Comment 4 2016-12-05 09:51:23 PST
Marked as flaky again in http://trac.webkit.org/projects/webkit/changeset/209323
Ryan Haddad
Comment 5 2017-01-24 10:29:17 PST
(In reply to comment #4) > Marked as flaky again in > http://trac.webkit.org/projects/webkit/changeset/209323 Once more in https://trac.webkit.org/r211090
Antoine Quint
Comment 6 2017-01-30 12:01:54 PST
This hasn't been flaky on Apple bots for 3 days.
Antoine Quint
Comment 7 2017-01-31 02:59:31 PST
Marked as flaky on Debug El Capitan only in http://trac.webkit.org/changeset/211423.
Antoine Quint
Comment 8 2017-02-02 05:23:53 PST
Created attachment 300400 [details] Patch
Antoine Quint
Comment 9 2017-02-02 05:25:44 PST
Created attachment 300401 [details] Patch for landing
WebKit Commit Bot
Comment 10 2017-02-02 06:27:48 PST
Comment on attachment 300401 [details] Patch for landing Clearing flags on attachment: 300401 Committed r211557: <http://trac.webkit.org/changeset/211557>
WebKit Commit Bot
Comment 11 2017-02-02 06:27:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.