Bug 164483

Summary:

[Mac][WK1] Implement new HTML interactive form validation user interface

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, barraclough, buildbot, cdumez, commit-queue, jonlee, ossy, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

165328

Bug Blocks:

164485, 164382

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews103 for mac-yosemite	none
WIP Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2016-11-07 09:42:06 PST

Implement new HTML interactive form validation user interface on Mac WebKit1, similarly to the one for WebKit2.

Attachments
WIP Patch (13.51 KB, patch) 2016-11-30 15:00 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (15.39 KB, patch) 2016-11-30 16:56 PST, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-yosemite (1.59 MB, application/zip) 2016-11-30 18:14 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-yosemite (1010.82 KB, application/zip) 2016-11-30 18:19 PST, Build Bot	no flags	Details
WIP Patch (17.01 KB, patch) 2016-12-01 09:52 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.58 KB, patch) 2016-12-01 10:15 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.57 KB, patch) 2016-12-01 10:31 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.71 KB, patch) 2016-12-01 10:33 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.79 KB, patch) 2016-12-01 10:42 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-11-30 15:00:22 PST

Created attachment 295775 [details] WIP Patch

WebKit Commit Bot

Comment 2 2016-11-30 15:02:24 PST

Attachment 295775 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2016-11-30 16:56:14 PST

Created attachment 295792 [details] WIP Patch

WebKit Commit Bot

Comment 4 2016-11-30 17:06:53 PST

Attachment 295792 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2016-11-30 18:14:42 PST

Comment on attachment 295792 [details] WIP Patch Attachment 295792 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2598317 New failing tests: fast/forms/validation-message-on-listbox.html fast/forms/validation-message-on-menulist.html fast/forms/validation-message-on-radio.html fast/forms/validation-message-on-checkbox.html fast/forms/validation-message-on-range.html fast/forms/validation-message-clone.html fast/forms/validation-message-in-relative-body.html fast/forms/validation-message-appearance.html fast/forms/validation-message-on-textarea.html

Build Bot

Comment 6 2016-11-30 18:14:45 PST

Created attachment 295805 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-11-30 18:19:38 PST

Comment on attachment 295792 [details] WIP Patch Attachment 295792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2598360 New failing tests: fast/forms/validation-message-on-listbox.html fast/forms/validation-message-on-menulist.html fast/forms/validation-message-on-radio.html fast/forms/validation-message-on-checkbox.html fast/forms/validation-message-on-range.html fast/forms/validation-message-clone.html fast/forms/validation-message-in-relative-body.html fast/forms/validation-message-appearance.html fast/forms/validation-message-on-textarea.html

Build Bot

Comment 8 2016-11-30 18:19:41 PST

Created attachment 295806 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 9 2016-12-01 09:52:35 PST

Created attachment 295856 [details] WIP Patch

Chris Dumez

Comment 10 2016-12-01 10:15:37 PST

Created attachment 295857 [details] Patch

WebKit Commit Bot

Comment 11 2016-12-01 10:17:39 PST

Attachment 295857 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 12 2016-12-01 10:31:21 PST

Created attachment 295861 [details] Patch

WebKit Commit Bot

Comment 13 2016-12-01 10:32:37 PST

Attachment 295861 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 14 2016-12-01 10:33:29 PST

Created attachment 295862 [details] Patch

WebKit Commit Bot

Comment 15 2016-12-01 10:35:25 PST

Attachment 295862 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 16 2016-12-01 10:42:29 PST

Created attachment 295864 [details] Patch

WebKit Commit Bot

Comment 17 2016-12-01 10:45:17 PST

Attachment 295864 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 18 2016-12-01 11:18:14 PST

<rdar://problem/29462758>

Chris Dumez

Comment 19 2016-12-01 14:02:08 PST

Comment on attachment 295864 [details] Patch Patch is ready for review.

WebKit Commit Bot

Comment 20 2016-12-02 12:05:30 PST

Comment on attachment 295864 [details] Patch Clearing flags on attachment: 295864 Committed r209252: <http://trac.webkit.org/changeset/209252>

WebKit Commit Bot

Comment 21 2016-12-02 12:05:36 PST

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 22 2016-12-02 13:21:05 PST

(In reply to comment #20) > Comment on attachment 295864 [details] > Patch > > Clearing flags on attachment: 295864 > > Committed r209252: <http://trac.webkit.org/changeset/209252> It broke the Apple Mac cmake build, see build.webkit.org for details.

Csaba Osztrogonác

Comment 23 2016-12-05 03:48:40 PST

the super easy buildfix landed in https://trac.webkit.org/changeset/209315

Alex Christensen

Comment 24 2016-12-05 10:49:37 PST

Thanks, Ossy!

Note You need to log in before you can comment on or make changes to this bug.