Bug 164466

Summary: IndexedDB 2.0: Clean up more transaction abort behavior, including tweaks to Index/ObjectStore lifetime
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, cdumez, commit-queue, esprehn+autocc, jsbell, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160306    
Attachments:
Description Flags
patch v1
none
Patch
achristensen: review+, beidson: commit-queue-
Patch for landing commit-queue: commit-queue-

Brady Eidson
Reported 2016-11-06 14:07:02 PST
IndexedDB 2.0: Clean up more transaction abort behavior, including tweaks to Index/ObjectStore lifetime
Attachments
patch v1 (64.06 KB, patch)
2016-11-06 14:19 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (44.17 KB, patch)
2016-11-07 10:52 PST, Brady Eidson 		achristensen: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (44.88 KB, patch)
2016-11-09 10:23 PST, Brady Eidson 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-11-06 14:19:43 PST
Created attachment 294035 [details] patch v1
WebKit Commit Bot
Comment 2 2016-11-06 14:21:51 PST
Attachment 294035 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2016-11-07 10:52:49 PST
Created attachment 294070 [details] Patch
Brady Eidson
Comment 4 2016-11-09 10:23:28 PST
Created attachment 294236 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-11-09 11:04:07 PST
The commit-queue encountered the following flaky tests while processing attachment 294236 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2016-11-09 11:04:43 PST
The commit-queue encountered the following flaky tests while processing attachment 294236 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2016-11-09 12:09:33 PST
Comment on attachment 294236 [details] Patch for landing Rejecting attachment 294236 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 294236, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 231. Hunk #9 FAILED at 17334. Hunk #10 succeeded at 21826 (offset 13 lines). Hunk #11 FAILED at 25089. Hunk #12 FAILED at 26802. Hunk #13 FAILED at 28845. Hunk #14 succeeded at 28881 (offset 12 lines). 10 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/bindings/js/JSIDBTransactionCustom.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2484714
Brady Eidson
Comment 8 2016-11-09 12:26:32 PST
https://trac.webkit.org/changeset/208467
Brady Eidson
Comment 9 2016-11-09 13:01:27 PST
The pointer -> ref followup landed in https://trac.webkit.org/changeset/208471
Note You need to log in before you can comment on or make changes to this bug.