Bug 164426

Summary: RenderFlowThread state reset cleanup.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2016-11-04 13:26:31 PDT
RenderFlow state reset is spread across several functions.
Attachments
Patch (8.25 KB, patch)
2016-11-04 15:16 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.35 KB, patch)
2016-11-04 18:11 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-11-04 15:16:30 PDT
Created attachment 293942 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-11-04 15:24:33 PDT
Comment on attachment 293942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293942&action=review > Source/WebCore/ChangeLog:24 > + (WebCore::RenderObject::initializeFlowThreadState): This is in transition for webkit.org/b/164428 (RenderFlowThread state initialization cleanup.) > + (WebCore::RenderObject::resetFlowThreadState): Maybe "onInsertion", "onRemoval".
alan
Comment 3 2016-11-04 18:11:18 PDT
Created attachment 293966 [details] Patch
WebKit Commit Bot
Comment 4 2016-11-04 19:00:43 PDT
The commit-queue encountered the following flaky tests while processing attachment 293966 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2016-11-04 19:01:27 PDT
The commit-queue encountered the following flaky tests while processing attachment 293966 [details]: inspector/sampling-profiler/call-frame-with-dom-functions.html bug 164399 (author: sbarati@apple.com) transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2016-11-04 20:00:38 PDT
Comment on attachment 293966 [details] Patch Clearing flags on attachment: 293966 Committed r208414: <http://trac.webkit.org/changeset/208414>
WebKit Commit Bot
Comment 7 2016-11-04 20:00:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.