Bug 164401

Summary:

[MAC][WK2] Add support for uiController.typeCharacterUsingHardwareKeyboard()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

ASSIGNED

Severity:

Normal

CC:

lforschler, simon.fraser, wenson_hsieh

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

164143

Bug Blocks:

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
WIP patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none

Chris Dumez

Reported 2016-11-03 21:37:15 PDT

Add support for uiController.typeCharacterUsingHardwareKeyboard() on Mac and use it to improve an existing test.

Attachments
Patch (13.55 KB, patch) 2016-11-03 21:42 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
WIP patch (55.48 KB, patch) 2016-11-03 21:42 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.06 MB, application/zip) 2016-11-03 23:00 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-11-03 21:42:11 PDT

Created attachment 293857 [details] Patch

Simon Fraser (smfr)

Comment 2 2016-11-03 21:42:34 PDT

Created attachment 293858 [details] WIP patch Attaching something I hacked up a while back. I forget the state of it though.

Build Bot

Comment 3 2016-11-03 23:00:39 PDT

Comment on attachment 293857 [details] Patch Attachment 293857 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2459581 New failing tests: fast/forms/validation-messages.html

Build Bot

Comment 4 2016-11-03 23:00:43 PDT

Created attachment 293869 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 5 2016-11-04 08:45:43 PDT

(In reply to comment #3) > Comment on attachment 293857 [details] > Patch > > Attachment 293857 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/2459581 > > New failing tests: > fast/forms/validation-messages.html For some reason, typeCharacterUsingHardwareKeyboard() seems to fail to type letter 'a' in the field on iOS. Works on Mac though.

Wenson Hsieh

Comment 6 2016-11-04 08:47:23 PDT

I think you need to tap the input field in order for typeCharacterUsingHardwareKeyboard to work on WK2 iOS.

Chris Dumez

Comment 7 2016-11-04 09:21:38 PDT

(In reply to comment #6) > I think you need to tap the input field in order for > typeCharacterUsingHardwareKeyboard to work on WK2 iOS. Ok, so using typeCharacterUsingHardwareKeyboard() is not really helping me make my test cross platform (Mac and iOS) :/

Note You need to log in before you can comment on or make changes to this bug.