Bug 163749

Summary:

IndexedDB 2.0: Support IDBObjectStore name assignment

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, buildbot, cdumez, commit-queue, esprehn+autocc, jsbell, kondapallykalyan, rniwa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

160306

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none

Brady Eidson

Reported 2016-10-20 12:38:22 PDT

IndexedDB 2.0: Support IDBObjectStore name assignment

Attachments
Patch (70.95 KB, patch) 2016-10-20 12:43 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.42 MB, application/zip) 2016-10-20 13:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.76 MB, application/zip) 2016-10-20 13:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (888.46 KB, application/zip) 2016-10-20 13:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (10.18 MB, application/zip) 2016-10-20 13:58 PDT, Build Bot	no flags	Details
Patch (78.86 KB, patch) 2016-10-20 14:31 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2016-10-20 12:38:46 PDT

<rdar://problem/28806931>

Brady Eidson

Comment 2 2016-10-20 12:43:27 PDT

Created attachment 292238 [details] Patch

Alex Christensen

Comment 3 2016-10-20 13:10:23 PDT

Comment on attachment 292238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292238&action=review test renaming an object store to an existing object store's name. > Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:115 > + return Exception { INVALID_STATE_ERR, makeString(ASCIILiteral("Failed set property 'name' on 'IDBObjectStore': The database already has an object store named '"), name, ASCIILiteral("'.")) }; I'm not sure if ASCIILiteral helps if it's inside a makeString. > LayoutTests/storage/indexeddb/resources/readonly.js:-33 > - setReadonlyProperty("objectStore.name", "'bar'"); Explain why this is removed in the changelog.

Build Bot

Comment 4 2016-10-20 13:29:54 PDT

Comment on attachment 292238 [details] Patch Attachment 292238 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2332893 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

Build Bot

Comment 5 2016-10-20 13:29:58 PDT

Created attachment 292243 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-10-20 13:52:38 PDT

Comment on attachment 292238 [details] Patch Attachment 292238 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2332947 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

Build Bot

Comment 7 2016-10-20 13:52:42 PDT

Created attachment 292247 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-10-20 13:56:23 PDT

Comment on attachment 292238 [details] Patch Attachment 292238 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2333027 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

Build Bot

Comment 9 2016-10-20 13:56:27 PDT

Created attachment 292253 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-10-20 13:58:19 PDT

Comment on attachment 292238 [details] Patch Attachment 292238 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2332982 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

Build Bot

Comment 11 2016-10-20 13:58:23 PDT

Created attachment 292257 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Brady Eidson

Comment 12 2016-10-20 14:31:55 PDT

Created attachment 292264 [details] Patch

Brady Eidson

Comment 13 2016-10-20 14:34:38 PDT

Relying on EWS to sort out layouttest issues, will cq+ once green.

Brady Eidson

Comment 14 2016-10-20 15:42:35 PDT

The current ios-sim failure is unrelated stuff. cq+'ing

WebKit Commit Bot

Comment 15 2016-10-20 16:06:06 PDT

Comment on attachment 292264 [details] Patch Clearing flags on attachment: 292264 Committed r207641: <http://trac.webkit.org/changeset/207641>

WebKit Commit Bot

Comment 16 2016-10-20 16:06:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.