Bug 163411

Summary: REGRESSION (r207299): media/modern-media-controls/pip-button/pip-button.html and media/modern-media-controls/skip-back-button/skip-back-button.html are flaky
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, graouts, graouts
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Ryan Haddad
Reported 2016-10-13 15:33:06 PDT
media/modern-media-controls/pip-button/pip-button.html and media/modern-media-controls/skip-back-button/skip-back-button.html are flaky https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r207308%20(9047)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fskip-back-button%2Fskip-back-button.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fpip-button%2Fpip-button.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/pip-button/pip-button-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/pip-button/pip-button-actual.txt @@ -8,7 +8,7 @@ PASS pipButton.element.classList.contains("pip") is true PASS pipButton.iconName is "pip-in" PASS pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@") is true -PASS iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@") is true +FAIL iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@") should be true. Was false. PASS successfullyParsed is true TEST COMPLETE --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/skip-back-button/skip-back-button-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/skip-back-button/skip-back-button-actual.txt @@ -8,7 +8,7 @@ PASS skipBackButton.element.classList.contains("skip-back") is true PASS skipBackButton.iconName is "interval-skip-back" PASS skipBackButton.element.style.webkitMaskImage.includes("macOS/interval-skip-back@") is true -PASS iOSSkipBackButton.element.style.webkitMaskImage.includes("iOS/interval-skip-back@") is true +FAIL iOSSkipBackButton.element.style.webkitMaskImage.includes("iOS/interval-skip-back@") should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch for landing (8.13 KB, patch)
2016-10-14 01:12 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-10-14 00:03:51 PDT
Similar to https://bugs.webkit.org/show_bug.cgi?id=163248 and https://bugs.webkit.org/show_bug.cgi?id=163249, I'll change all tests that check on loaded resources to use the same approach.
Antoine Quint
Comment 2 2016-10-14 01:12:49 PDT
Created attachment 291590 [details] Patch for landing
WebKit Commit Bot
Comment 3 2016-10-14 01:58:35 PDT
The commit-queue encountered the following flaky tests while processing attachment 291590 [details]: imported/w3c/web-platform-tests/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-support.htm bug 163438 (author: cdumez@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2016-10-14 01:58:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 291590 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2016-10-14 02:52:26 PDT
Comment on attachment 291590 [details] Patch for landing Clearing flags on attachment: 291590 Committed r207333: <http://trac.webkit.org/changeset/207333>
WebKit Commit Bot
Comment 6 2016-10-14 02:52:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.