Bug 163268

Summary: Annotate DOM API with CEReactions
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, cmarcelo, commit-queue, dbates, esprehn+autocc, gyuyoung.kim, kangil.han, koivisto, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Adds the IDL attribute darin: review+

Ryosuke Niwa
Reported 2016-10-10 21:51:20 PDT
Add CEReactions IDL attribute to APIs defined in https://dom.spec.whatwg.org
Attachments
Adds the IDL attribute (87.49 KB, patch)
2016-10-10 22:06 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-10-10 22:06:32 PDT
Created attachment 291229 [details] Adds the IDL attribute
Radar WebKit Bug Importer
Comment 2 2016-10-10 22:16:44 PDT
<rdar://problem/28708977>
Darin Adler
Comment 3 2016-10-10 23:54:24 PDT
Comment on attachment 291229 [details] Adds the IDL attribute View in context: https://bugs.webkit.org/attachment.cgi?id=291229&action=review > Source/WebCore/dom/NamedNodeMap.idl:30 > + [MayThrowLegacyException, CEReactions] Attr removeNamedItem(DOMString name); Should figure out what order we want these extended attributes. I was thinking maybe alphabetical.
Ryosuke Niwa
Comment 4 2016-10-10 23:57:09 PDT
Comment on attachment 291229 [details] Adds the IDL attribute View in context: https://bugs.webkit.org/attachment.cgi?id=291229&action=review >> Source/WebCore/dom/NamedNodeMap.idl:30 >> + [MayThrowLegacyException, CEReactions] Attr removeNamedItem(DOMString name); > > Should figure out what order we want these extended attributes. I was thinking maybe alphabetical. Hopefully MayThrowLegacyException is going away but alphabetical ordering makes sense. We should probably add that to the style checker...
Ryosuke Niwa
Comment 5 2016-10-11 15:10:26 PDT
Committed r207170: <http://trac.webkit.org/changeset/207170>
Note You need to log in before you can comment on or make changes to this bug.