Bug 161916

Summary: [CSS Parser] Add CSS Variable Parsing support
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CanvasAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 46591    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Dave Hyatt
Reported 2016-09-13 11:04:58 PDT
[CSS Parser] Add CSS Variable Parsing support
Attachments
Patch (60.13 KB, patch)
2016-09-13 11:08 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (60.09 KB, patch)
2016-09-13 11:13 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-09-13 11:08:28 PDT
Created attachment 288701 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-13 11:11:25 PDT
Attachment 288701 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSVariableData.cpp:51: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/CSSVariableData.h:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2016-09-13 11:13:10 PDT
Created attachment 288703 [details] Patch
Dave Hyatt
Comment 4 2016-09-13 12:10:49 PDT
Landed in r205869.
Note You need to log in before you can comment on or make changes to this bug.