Bug 161223

Summary: ews queues should update status server when they start processing patch
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, glenn, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161222
https://bugs.webkit.org/show_bug.cgi?id=161220
Attachments:
Description Flags
Proposed patch
dbates: review+
Updated patch none

Aakash Jain
Reported 2016-08-25 18:54:56 PDT
Currently EWS status page (or bubbles on bug) does not indicate clearly when the patch is started processing (and by which bot). Bots should update the status to status-server when they start processing patch. This would also help in https://bugs.webkit.org/show_bug.cgi?id=161222
Attachments
Proposed patch (1.19 KB, patch)
2016-08-25 18:59 PDT, Aakash Jain 		dbates: review+
DetailsFormatted DiffDiff
Updated patch (4.94 KB, patch)
2016-08-25 20:03 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2016-08-25 18:59:21 PDT
Created attachment 287059 [details] Proposed patch
Daniel Bates
Comment 2 2016-08-25 19:28:22 PDT
Comment on attachment 287059 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287059&action=review > Tools/Scripts/webkitpy/tool/commands/queues.py:448 > + self._update_status("Started processing patch", patch) Does it make sense to add a unit test for this change?
Aakash Jain
Comment 3 2016-08-25 20:03:53 PDT
Created attachment 287066 [details] Updated patch Yes, you are right, I missed updating the unit tests. We should start running test-webkitpy on every patch in EWS.
WebKit Commit Bot
Comment 4 2016-08-25 22:35:43 PDT
Comment on attachment 287066 [details] Updated patch Clearing flags on attachment: 287066 Committed r205003: <http://trac.webkit.org/changeset/205003>
WebKit Commit Bot
Comment 5 2016-08-25 22:35:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.