Bug 161219

Summary: Regression(r204605): WebCore::checkExistingName() logs error messages on iOS
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: ASSIGNED    
Severity: Normal CC: ap, cdumez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 160931    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-08-25 16:26:21 PDT
WebCore::checkExistingName() logs error messages on iOS after r204605: ERROR: alias x-mac-cyrillic maps to x-mac-cyrillic already, but someone is trying to make it map to macos-7_3-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias windows-10007 maps to x-mac-cyrillic already, but someone is trying to make it map to macos-7_3-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias mac-cyrillic maps to x-mac-cyrillic already, but someone is trying to make it map to macos-7_3-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias maccy maps to x-mac-cyrillic already, but someone is trying to make it map to macos-7_3-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-MacCyrillic maps to x-mac-cyrillic already, but someone is trying to make it map to macos-7_3-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-MacUkraine maps to x-mac-cyrillic already, but someone is trying to make it map to macos-7_3-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-mac-greek maps to x-mac-greek already, but someone is trying to make it map to macos-6_2-10.4 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias windows-10006 maps to x-mac-greek already, but someone is trying to make it map to macos-6_2-10.4 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias macgr maps to x-mac-greek already, but someone is trying to make it map to macos-6_2-10.4 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-MacGreek maps to x-mac-greek already, but someone is trying to make it map to macos-6_2-10.4 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-mac-centraleurroman maps to x-mac-centraleurroman already, but someone is trying to make it map to macos-29-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias windows-10029 maps to x-mac-centraleurroman already, but someone is trying to make it map to macos-29-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-mac-ce maps to x-mac-centraleurroman already, but someone is trying to make it map to macos-29-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias macce maps to x-mac-centraleurroman already, but someone is trying to make it map to macos-29-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias maccentraleurope maps to x-mac-centraleurroman already, but someone is trying to make it map to macos-29-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-MacCentralEurope maps to x-mac-centraleurroman already, but someone is trying to make it map to macos-29-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-mac-turkish maps to x-mac-turkish already, but someone is trying to make it map to macos-35-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias windows-10081 maps to x-mac-turkish already, but someone is trying to make it map to macos-35-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias mactr maps to x-mac-turkish already, but someone is trying to make it map to macos-35-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *) ERROR: alias x-MacTurkish maps to x-mac-turkish already, but someone is trying to make it map to macos-35-10.2 /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/text/TextEncodingRegistry.cpp(138) : void WebCore::checkExistingName(const char *, const char *)
Attachments
Patch (3.82 KB, patch)
2016-08-25 16:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-25 16:35:42 PDT
Created attachment 287043 [details] Patch
Alexey Proskuryakov
Comment 2 2016-08-25 20:44:58 PDT
Comment on attachment 287043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287043&action=review > Source/WebCore/ChangeLog:12 > + I also dropped to 2 remaining ones (macos-6-10.2, softbank-sjis) because: The latter is scary, I'm pretty sure that it is the important on iOS - although I do not know if it gets used in WebKit specifically.
Note You need to log in before you can comment on or make changes to this bug.