Bug 160244
| Summary: | [Wayland] PlatformDisplay crash when calling wl_proxy_destroy in exit handler | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro, zan |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://bugzilla.redhat.com/show_bug.cgi?id=1357119 https://bugzilla.redhat.com/show_bug.cgi?id=1325815 https://bugzilla.redhat.com/show_bug.cgi?id=1364284 https://bugzilla.redhat.com/show_bug.cgi?id=1330116 |
||
| Bug Depends on: | |||
| Bug Blocks: | 81456 | ||
Michael Catanzaro
I have one report (meaning it's very rare) of a crash when the PlatformDisplayWayland destructor is called in an exit handler, inside wl_proxy_destroy:
Thread 1 (Thread 0x7f3bca75dac0 (LWP 3269)):
#0 wl_proxy_destroy (proxy=0x7f3b00000000) at src/wayland-client.c:438
display = <optimized out>
#1 0x00007f3bc968d8e0 in wl_webkitgtk_destroy (wl_webkitgtk=<optimized out>) at /usr/src/debug/webkitgtk-2.12.3/x86_64-redhat-linux-gnu/DerivedSources/WebCore/WebKitGtkWaylandClientProtocol.h:70
No locals.
#2 WebCore::PlatformDisplayWayland::~PlatformDisplayWayland (this=0x7f3b42aa06c0, __in_chrg=<optimized out>) at /usr/src/debug/webkitgtk-2.12.3/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp:111
No locals.
#3 0x00007f3bc968d929 in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland (this=0x7f3b42aa06c0, __in_chrg=<optimized out>) at /usr/src/debug/webkitgtk-2.12.3/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp:118
No locals.
#4 0x00007f3bbe52a1e8 in __run_exit_handlers (status=status@entry=0, listp=0x7f3bbe8ad5d8 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true) at exit.c:82
atfct = <optimized out>
onfct = <optimized out>
cxafct = <optimized out>
f = <optimized out>
#5 0x00007f3bbe52a235 in __GI_exit (status=status@entry=0) at exit.c:104
No locals.
#6 0x00007f3bc86346b3 in IPC::Connection::didFailToSendSyncMessage (this=this@entry=0x7f3bb4de9000) at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/Connection.cpp:873
No locals.
Note it's triggered by didFailToSendSyncMessage. Full backtrace downstream.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
I take that back, we have 13 reports of this. Still relatively rare.
I forgot to mention, this is very similar to bug #157973.
Michael Catanzaro
Got two users who report this can be triggered by using Epiphany's bookmarks import feature. (Yeah....) It also crashes GNOME shell.
Michael Catanzaro
Note that using exit-time destructors like this is a violation of our programming guidelines, and why we have NeverDestroyed.
Michael Catanzaro
(In reply to comment #1)
> I take that back, we have 13 reports of this. Still relatively rare.
Now we're up to 271 reports
Carlos Garcia Campos
This could be fixed by patch attached to bug #115803, since PlatformDisplayWayland no longer creates a wl_webkitgtk object.
Carlos Garcia Campos
Please, reopen this if it still fails after r205116