Bug 159868

Summary: [Streams API] Make ReadableStream properties not enumerable
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, romain.wkt
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138561    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2016-07-18 00:16:50 PDT
According wpt tests, ReadableStream et al interfaces are not perfectly aligned with the test/spec
Attachments
Patch (10.88 KB, patch)
2016-07-18 00:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.96 KB, patch)
2016-07-18 00:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.96 KB, patch)
2016-07-19 00:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-07-18 00:26:15 PDT
Created attachment 283886 [details] Patch
youenn fablet
Comment 2 2016-07-18 00:29:01 PDT
Created attachment 283887 [details] Patch
Darin Adler
Comment 3 2016-07-18 09:57:12 PDT
Comment on attachment 283887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283887&action=review It’s surprising none of these are enumerable. Is this some kind of new trend in modern DOM APIs? > Source/WebCore/Modules/streams/ReadableStream.js:108 > + const options = (arguments.length > 1) ? arguments[1] : @undefined; How is this different from: const options = arguments[1]; I don’t understand how the explicit length check has any effect.
youenn fablet
Comment 4 2016-07-19 00:27:14 PDT
(In reply to comment #3) > Comment on attachment 283887 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283887&action=review > > It’s surprising none of these are enumerable. Is this some kind of new trend > in modern DOM APIs? WebIDL is prescribing enumerable attributes/functions. JavaScript APIs are mostly not-enumerable AFAIK. This is the case for promises and arrays for instance. I also think that JS classes functions are not enumerable as well. > > Source/WebCore/Modules/streams/ReadableStream.js:108 > > + const options = (arguments.length > 1) ? arguments[1] : @undefined; > > How is this different from: > > const options = arguments[1]; > > I don’t understand how the explicit length check has any effect. Right, I removed the check.
youenn fablet
Comment 5 2016-07-19 00:28:19 PDT
Created attachment 283983 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-07-19 01:00:00 PDT
Comment on attachment 283983 [details] Patch for landing Clearing flags on attachment: 283983 Committed r203402: <http://trac.webkit.org/changeset/203402>
WebKit Commit Bot
Comment 7 2016-07-19 01:00:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.