Bug 159669

Summary: JSCOnly bulidfix after r203078
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, commit-queue, gyuyoung.kim, mmaxfield, ossy, ysuzuki
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159598    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2016-07-12 00:23:48 PDT
https://trac.webkit.org/changeset/203078 broke the build on JSCOnly port: lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::wordBreakIterator(WTF::StringView)': TextBreakIterator.cpp:(.text+0x238): undefined reference to `WTF::currentTextBreakLocaleID()' lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::sentenceBreakIterator(WTF::StringView)': TextBreakIterator.cpp:(.text+0x3a0): undefined reference to `WTF::currentTextBreakLocaleID()' lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::openLineBreakIterator(WTF::AtomicString const&, WTF::LineBreakIteratorMode, bool)': TextBreakIterator.cpp:(.text+0x790): undefined reference to `WTF::currentTextBreakLocaleID()' TextBreakIterator.cpp:(.text+0x7bc): undefined reference to `WTF::currentTextBreakLocaleID()' lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView)': TextBreakIterator.cpp:(.text+0xc58): undefined reference to `WTF::currentTextBreakLocaleID()' collect2: error: ld returned 1 exit status It seems JSCOnly port should have currentTextBreakLocaleID() since this patch, fix is coming.
Attachments
Patch (2.68 KB, patch)
2016-07-12 00:28 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-07-12 00:28:46 PDT
Created attachment 283395 [details] Patch
Csaba Osztrogonác
Comment 2 2016-07-12 00:30:25 PDT
Comment on attachment 283395 [details] Patch Speculative fix, simply duplicate the GTK's dummy implementation. I'll be able to test it in ~3 hours.
Csaba Osztrogonác
Comment 3 2016-07-12 03:47:56 PDT
Comment on attachment 283395 [details] Patch build tested, it works
Yusuke Suzuki
Comment 4 2016-07-12 04:08:41 PDT
Comment on attachment 283395 [details] Patch r=me, it is the same to GTK, and EFL.
WebKit Commit Bot
Comment 5 2016-07-12 04:30:01 PDT
Comment on attachment 283395 [details] Patch Clearing flags on attachment: 283395 Committed r203112: <http://trac.webkit.org/changeset/203112>
WebKit Commit Bot
Comment 6 2016-07-12 04:30:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.