Bug 158894

Summary: DatabaseProcess doesn't handle WebProcesses going away uncleanly
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, ap, beidson, commit-queue, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Alex Christensen
Reported 2016-06-17 17:37:35 PDT
IDB won't open any databases
Attachments
Patch (5.05 KB, patch)
2016-06-17 17:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.65 KB, patch)
2016-06-22 16:08 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-06-17 17:37:58 PDT
Created attachment 281599 [details] Patch
Brady Eidson
Comment 2 2016-06-17 19:31:02 PDT
Comment on attachment 281599 [details] Patch r- because what is this
Brady Eidson
Comment 3 2016-06-22 13:15:51 PDT
DatabaseProcess doesn't handle WebProcesses going away uncleanly This code: void DatabaseToWebProcessConnection::didClose(IPC::Connection&) { #if ENABLE(INDEXED_DATABASE) // FIXME: (Modern IDB) The WebProcess has disconnected, close all of the connections associated with it #endif } Yikes!
Brady Eidson
Comment 4 2016-06-22 13:17:08 PDT
This test case exacerbates the issue because it opens a new database connection each time through the test. When a tab is closed in Safari, sometimes we shut down a few of those connections, but most just disappear without a trace, forever clogging the database process.
Brady Eidson
Comment 5 2016-06-22 14:22:10 PDT
As is the common thread lately, I have a straightforward fix, and writing a test will take awhile.
Brady Eidson
Comment 6 2016-06-22 16:08:06 PDT
Created attachment 281880 [details] Patch
Brady Eidson
Comment 7 2016-06-22 16:46:33 PDT
http://trac.webkit.org
Brady Eidson
Comment 8 2016-06-22 16:52:26 PDT
http://trac.webkit.org/changeset/202359
Note You need to log in before you can comment on or make changes to this bug.